1924086 - Implement the `position-area` property

Status: RESOLVED FIXED

(Core :: Layout: Positioned, enhancement)

Description

[David Shin[:dshin]]

As per spec - need to come up with the 3x3 area.
Mostly straightforward, except perhaps when the anchor element is bigger than the absolute containing area.

Comment 1

[Jonathan Watt [:jwatt]]

I'm not sure this is straightforward. Note that this involves writing modes (so the writing-mode, direction, and text-orientation properties), and the writing modes spec has a reputation for being gnarly. Specifically, we'll need to normalize abstract values to physical values. Further complicating things from that already complicated table, the position-area property can reference both a self-* and non-self-* keyword, pulling writing mode information from more than one element.

Comment 2

[Jonathan Watt [:jwatt]]

Sorry, wrong bug.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: Bug 1924086. Implement position-area property. r=dshin

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: Bug 1924086. Adjust WPT expectations for position-area support. r=dshin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9df5d8080954
https://hg.mozilla.org/integration/autoland/rev/6b0508b20dd2
Implement position-area property. r=dshin,firefox-style-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/0100e484f423
https://hg.mozilla.org/integration/autoland/rev/6c6e2fd09271
Adjust WPT expectations for position-area support. r=dshin,layout-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/97cd4f204b51
https://hg.mozilla.org/integration/autoland/rev/14094dd3879c
Revert "Bug 1924086. Adjust WPT expectations for position-area support. r=dshin,layout-reviewers" for causing Wr failures on position-visibility-anchors-visible-non-intervening-container.html

Comment 8

[Cristina Horotan [:chorotan]]

Backed out for causing Wr failures on position-visibility-anchors-visible-non-intervening-container.html

Backout link

Push with failures

Failure log

Comment 9

[Jonathan Watt [:jwatt]]

TEST-UNEXPECTED-FAIL | /css/css-anchor-position/position-visibility-anchors-visible-non-intervening-container.html
INFO - Found 1 pixels different, maximum difference per channel 92

Needs a tiny big of fuzz I guess.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/701a0c571ad5
https://hg.mozilla.org/integration/autoland/rev/5c200c0c93b7
Implement position-area property. r=dshin,firefox-style-system-reviewers
https://github.com/mozilla-firefox/firefox/commit/c66a1b9ed126
https://hg.mozilla.org/integration/autoland/rev/58e363ee9f9a
Adjust WPT expectations for position-area support. r=dshin,layout-reviewers

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5c200c0c93b7
https://hg.mozilla.org/mozilla-central/rev/58e363ee9f9a