1924095 - Backup regeneration is triggered by normal cookie deletion, not just user-triggered deletion

Status: RESOLVED FIXED

(Firefox :: Profile Backup, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Despite bug 1923125 landing, I'm still seeing frequent regeneration with the cookie-changed observer getting notifications about COOKIE_DELETED. It looks like our observer isn't correctly distinguishing between "natural" cookie deletions, and cookie deletions triggered by an explicit user action.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey Tim,

Do you happen to know if there's a way to determine if a cookie deletion was caused by the user, say, clearing cookies/site data in about:preferences vs a cookie being deleted naturally by a site?

Comment 2

[Tim Huang[:timhuang]]

I think you can check the nsICookieNotification.browsingContextId to know if it's from a site or not. It should be zero if the deletion is from the Chrome UI.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Perfect, thanks!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1924095 - Don't regenerate backups when cookies are removed by the site. r?#backup-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baa459e5df1f
Don't regenerate backups when cookies are removed by the site. r=backup-reviewers,sthompson

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/baa459e5df1f