1924107 - History sidebar has a "..." menu button that is not labeled

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Anna Yeddi [:ayeddi]]

Attachment: NVDA output for Sidebar History panel where the "..." button has attached menu opened but is only announced as Button

Prerequisites:

1. Ensure a screen reader is running, i.e. NVDA on WinOS

STR:

1. In Firefox, ensure the sidebar.revamp pref is set to true and the new sidebar is visible
2. Locate and activate History panel of the sidebar
3. Locate and navigate to the ... (sorting) control after the search input and observe the screen reader announcement

Expected:

1. Role, name, and state of the control is announced, i.e. Sorting, menu button, collapsed

Actual:

1. The button is missing its accessible name (is unlabeled)
2. The button that serves as a menu button lacks both aria-expanded and aria-haspopup=menu attributes

This is an access-S2 issue that makes this part of the UI, including the attached menu, inaccessible for users of assistive technologies. Users with voice control won't be able to call its name to activate it, users of screen readers won't know what is the purpose of this button. Learn more about ways to make image buttons accessible in the W3C WAI Tutorials

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:sclements, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Sarah Clements [:sclements]]

Attachment: Bug 1924107 - Add missing title and aria attributes to menu buttons in sidebar r=#sidebar-reviewers,Mardak

Comment 4

[Sarah Clements [:sclements]]

I noticed the chatbot panel has the same pattern of using the 3-dot button as a menu and is missing some of the same attributes, so I've updated there as well.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfc9c8d13810
Add missing title and aria attributes to menu buttons in sidebar r=Mardak,sidebar-reviewers,fluent-reviewers,Gijs

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing sidebar related failures

Backout link

Push with failures

Logs for the fails can be found in the push link above.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/304bd1114b5d
Add missing title and aria attributes to menu buttons in sidebar r=Mardak,sidebar-reviewers,fluent-reviewers,Gijs

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/304bd1114b5d

Comment 9

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 133.0a1 (2024-10-06) on Windows 10.
The issue is verified fixed with Firefox 134.0a1 (20241105092845) and Firefox 133.0b4(20241104091514) on Windows 10, Ubuntu 22 and macOS 14.