1924121 - Properly define the bounds of the stacking context snapshots

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Nicolas Silva [:nical]]

This bug is about making sure that we pass the right info to specify the bounds in local space of the snapshot, and honor that, potentially inflating or clipping the bounds of the resulting picture.

The general idea is similar to the blob image visible area.

Comment 1

[Nicolas Silva [:nical]]

This was fixed as part of bug 1921981.

Comment 2

[Nicolas Silva [:nical]]

Actually, I'm seeing incorrect snapshot bounds in some test cases so I'll reopen and use this bug to track the issue.

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1924121 - Offset the snapshot area by the stacking context origin. r=gw

This way the snapshot area is in the same coordinate space as items pushed in the stacking context, which is easier to reason about.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f84ebf147735
Offset the snapshot area by the stacking context origin. r=gw

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/f84ebf147735