1924155 - VideoBridgeParent AddRef and Release should use NS_IMETHOD macros

Status: RESOLVED INVALID

(Core :: Graphics: WebRender, defect)

Description

[Brad Werth [:bradwerth]]

Bug 1917652 declared explicit AddRef and Release methods for VideoBridgeParent, but used NS_IMETHODIMP_ macros for the declaration in the header. The "IMP" stands for "implementation" and those macros should only be used for the implementation. The header should use NS_IMETHOD_ instead

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1924155: Use correct declaration macros in VideoBridgeParent.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1cdaf575bc5
Use correct declaration macros in VideoBridgeParent. r=aosmond

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e1cdaf575bc5

Comment 4

[Sandor Molnar[:smolnar]]

Backed out because it caused conflict with backing out bug 1917652

Backout link: https://hg.mozilla.org/integration/autoland/rev/5444fbdc7dfcad2dc355b53eaf19fd6e255b69d4

Backout merge to central: https://hg.mozilla.org/mozilla-central/rev/7eb2b8f29bd184ae5600bf74d7d9b1d6750f7283

Comment 5

[Brad Werth [:bradwerth]]

This will be rolled into the fixup for Bug 1917652.