1924228 - Localize strings for Searchmode Switcher button

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Mandy Cheang [:mcheang][she/her]]

The strings for the Search Mode Switcher button are currently in an unlocalized file. You can view them here: https://searchfox.org/mozilla-central/source/browser/components/urlbar/content/enUS-searchFeatures.ftl#407.

This was done to avoid exposing translators to frequent changes during development. Now that we are preparing for release, we need to localize these strings.

Comment 1

[Adrian Florinescu [:aflorinescu]]

Mandy, could you confirm that this item will handle the special search modes - e.g. tabs, history, bookmarks? Also, should we log an enhancement to allow the intuitive english keywords as a default for all locales?

Comment 2

[Mandy Cheang [:mcheang][she/her]]

could you confirm that this item will handle the special search modes - e.g. tabs, history, bookmarks?

When this ticket is resolved, it will localize search mode chiclet for tabs, history, bookmarks, and actions. The intuitive keywords strings are already localized without this ticket. Please see screenshots for the chiclet and the intuitive keyword strings I've highlighted.

should we log an enhancement to allow the intuitive english keywords as a default for all locales?

If the keywords are not localized, the default will be en-US. There's no need to file another ticket for this.

Comment 3

[Mandy Cheang [:mcheang][she/her]]

Attachment: Screenshot 2024-10-16 at 10.30.05 AM.png

Comment 4

[Mandy Cheang [:mcheang][she/her]]

Attachment: Screenshot 2024-10-16 at 10.09.08 AM.png

Comment 5

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1924228 - Localize Searchmode Switcher Button strings into other languages. r=daleharvey

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1186b1ff771a
Localize Searchmode Switcher Button strings into other languages. r=daleharvey,fluent-reviewers

Comment 7

[Adrian Florinescu [:aflorinescu]]

(In reply to Mandy Cheang [:mcheang][she/her] from comment #2)

If the keywords are not localized, the default will be en-US. There's no need to file another ticket for this.

I was actually thinking/referring to having three sets of keywords for each locale - localized, english and old char.
e.g. for fr locale to be able to reach Tabs:

• @onglets
• @tabs
• %

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/1186b1ff771a

Comment 9

[Mandy Cheang [:mcheang][she/her]]

(In reply to Adrian Florinescu [:aflorinescu] from comment #7)

(In reply to Mandy Cheang [:mcheang][she/her] from comment #2)

If the keywords are not localized, the default will be en-US. There's no need to file another ticket for this.

I was actually thinking/referring to having three sets of keywords for each locale - localized, english and old char.
e.g. for fr locale to be able to reach Tabs:

• @onglets
• @tabs
• %

This is not a feature yet. We are thinking of implementing this later after the initial release.
I have a JIRA ticket for it here: https://mozilla-hub.atlassian.net/browse/SNG-1676
I need more time to discuss with UX how to implement it though because there's several solutions to be considered.

Right now, if the user is in fr locale, they will be able to activate Tabs search mode using:

@onglets
%

The JIRA ticket covers having the English @tabs when user is in a different language than en-US, so if the user is in fr they should be able to use these three:

@onglets
@tabs
 %

Back to your initial question, no need to file a ticket for this. I am already aware and will be working on it in the near future :)