1924328 - WebGPU: Support dual-source blending (`dual-source-blending` device feature)

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, enhancement, P3)

Description

[Erich Gubler [:ErichDonGubler] (he/him)]

Upstream WGPU issue: wgpu#6402

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1924328 - feat(webgpu): recognize unimplemented `dual-source-blending` feature r=#webgpu-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fec1334c4d2
feat(webgpu): recognize unimplemented `dual-source-blending` feature r=webgpu-reviewers,webidl,teoxoy,saschanaz

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5fec1334c4d2

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

I'm going to leave the full resolution of this bug for later. With bug 1933324, users will be directed to this bug to holler if they're blocked.

Comment 5

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: WIP: Bug 1924328 - feat(webgpu): recognize `GPUBlendFactor`s that require `dual-source-blending` feature r=#webgpu-reviewers!

Coverage for blend factors is mostly at webgpu:api,operation,rendering,color_target_state:blending,*, but these tests skip testing these factors if the dual-source-blending feature isn't supported. This change is mostly intended to improve diagnostics while waiting for dual-source-blending is implemented.

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1924328 - chore(webgpu): document reliance on `enum` discriminants matching for blend factors r=#webgpu-reviewers

Comment 7

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: WIP: Bug 1924328 - feat(webgpu): implement `dual-source-blending` r=#webgpu-reviewers!

Comment 8

[Erich Gubler [:ErichDonGubler] (he/him)]

I think the implementation should be trivial, now that upstream WGPU has an implementation that supposedly works. Fired off a Try push with some easy changes at try:c6309e98d743. 🤞🏻

Comment 9

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:ErichDonGubler, maybe it's time to close this bug?
For more information, please visit BugBot documentation.

Comment 10

[Erich Gubler [:ErichDonGubler] (he/him)]

Moving across the world entirely consumed my time for the last little bit. But I do plan on putting this over the line!

Comment 11

[Andy Leiserson [:aleiserson]]

Attachment: Bug 1924328 - WebGPU: Enable `dual-source-blending` feature, when available r=#webgpu-reviewers!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/41b180029e18
https://hg.mozilla.org/integration/autoland/rev/b19603ce8222
WebGPU: Enable `dual-source-blending` feature, when available r=webgpu-reviewers,webidl,saschanaz,ErichDonGubler

Comment 13

[rperta]

https://hg.mozilla.org/mozilla-central/rev/b19603ce8222

Comment 14

[Phabricator Automation]

Comment on attachment 9508993 [details]
Bug 1924328 - chore(webgpu): document reliance on enum discriminants matching for blend factors r=#webgpu-reviewers

Revision D262249 was moved to bug 2059417. Setting attachment 9508993 [details] to obsolete.

Comment 15

[Hamish Willee]

FF155 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/45176