Tidy up logins code in cZ
Categories
(SeaMonkey :: Chat, enhancement)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
4.62 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment there is only one caller for addOrUpdateLogin function and getLogin function is only used from static.js so there's no point it being in utils.js
Inline addOrUpdateLogin into cli_promptToSaveLogin function and move the getLogin function into static.js and streamline it.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
|
||
Comment 2•1 year ago
|
||
Comment on attachment 9430586 [details] [diff] [review]
1924336-irc-logins-25320.patch
lgtm r/a+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/69bd0907d6be
Tidy up logins code in cZ. r=frg
|
|
||
Comment 4•1 year ago
|
||
Comment on attachment 9430586 [details] [diff] [review]
1924336-irc-logins-25320.patch
upps reviewed but forgot to actually set r/a+
|
|
||
Comment 5•1 year ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/7357a59a735d4c165e083727bc30378e4aa25521
Tidy up logins code in cZ. r=frg a=frg
Description
•