Closed
Bug 1924521
Opened 4 months ago
Closed 4 months ago
EnumSerializer.h: simplify the code - do not use 'else' after 'return'
Categories
(Core :: IPC, task)
Core
IPC
Tracking
()
RESOLVED
FIXED
133 Branch
| Tracking | Status | |
|---|---|---|
| firefox133 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: smarshall, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Filling as a good first bug to learn workflows.
do not use 'else' after 'return':
https://searchfox.org/mozilla-central/rev/d56687458d4e6e8882c4b740e78413a0f0a69d59/ipc/glue/EnumSerializer.h#71
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by https://clang.llvm.org/extra/clang-tidy/checks/readability/else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Directly assigning it to someone
|
Assignee | |
Comment 1•4 months ago
|
||
Remove else-after-return, as per http://clang.llvm.org/extra/clang-tidy/checks/readability/else-after-return.html
|
||
Updated•4 months ago
|
Component: Source Code Analysis → IPC
Product: Developer Infrastructure → Core
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22e50e71b83a
Refactor IPC/EnumSerializer for readability r=sylvestre,ipc-reviewers,mccr8 DONTBUILD
|
||
Comment 3•4 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 months ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•