1924535 - Remove privacy.query_stripping.strip_on_share.canDisable in a few cycles

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P3)

Description

[Manuel Bucher [:manuel]]

Roughly 1-2 months after the release should be fine (Start of January, 2025) if there is no case for flipping that pref/reverting to the old behavior.
To reduce technical debt.

Introduced in Bug 1895334

Comment 1

[BugBot [:suhaib / :marco]]

2 months ago, manuel placed a reminder on the bug using the whiteboard tag [reminder-pref 2025-01-03] .

timhuang, please refer to the original comment to better understand the reason for the reminder.

Comment 2

[Manuel Bucher [:manuel]]

Extending reminder a bit. There has been discussions around the feature. Let's keep the pref for some more time.

Comment 3

[BugBot [:suhaib / :marco]]

a month ago, manuel placed a reminder on the bug using the whiteboard tag [reminder-pref 2025-03-03] .

timhuang, please refer to the original comment to better understand the reason for the reminder.

Comment 4

[Manuel Bucher [:manuel]]

I think we can remove the pref now.

Comment 5

[Mathew Hodson]

Attachment: Bug 1924535 - Remove privacy.query_stripping.strip_on_share.canDisable r=manuel

Comment 6

[Mathew Hodson]

I updated the patch with your review suggestions. Can you land this for me?

Comment 7

[Dão Gottwald [:dao]]

(In reply to Mathew Hodson from comment #6)

I updated the patch with your review suggestions. Can you land this for me?

Scheduled for landing. Thanks for the patch!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/613c818f5c45
https://hg.mozilla.org/integration/autoland/rev/a7748727c23b
Remove privacy.query_stripping.strip_on_share.canDisable r=manuel,urlbar-reviewers,mak

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/055d71eced48
https://hg.mozilla.org/integration/autoland/rev/b7097be148c0
Revert "Bug 1924535 - Remove privacy.query_stripping.strip_on_share.canDisable r=manuel,urlbar-reviewers,mak" for causing bc failures on browser_strip_on_share.js

Comment 10

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures on browser_strip_on_share.js

Backout link

Push with failures

Failure log

Comment 11

[Mathew Hodson]

Can you land this again?

Turns out you cannot use toggleAttribute for "disabled" on a XUL Element until bug 1914903 is fixed. See also bug 1938481.

Comment 12

[Mark Banner (:standard8)]

I've triggered landing as there's some other patches I want to be able to land, that currently conflict with this one.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/078264cfe20b
https://hg.mozilla.org/integration/autoland/rev/579465ce4ab7
Remove privacy.query_stripping.strip_on_share.canDisable r=manuel,urlbar-reviewers,mak

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/579465ce4ab7