1924542 - Manage Extensions Shortcuts should support function keys F13-F19

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[johndiamond]

Steps to reproduce:

• Open about:addons -> cog -> ManageExtensionShortcuts.
• Select a text input to update a shortcut binding
• Press a function key (F13, F14, ... F19)

For context I have an apple extended keyboard (https://store.storeimages.cdn-apple.com/4982/as-images.apple.com/is/MQ052?wid=1200&hei=500).

Actual results:

Nothing. It is as if the keypress is not detected.

Expected results:

A binding is created for the relevant key.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: UI Events & Focus Handling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[johndiamond]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #1)

The Bugbug bot thinks this bug should belong to the 'Core::DOM: UI Events & Focus Handling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

I have verified that these keys trigger DOM key events, so I don't think this is a DOM issue. This seems to be specific to "Manage Extension Shortcuts". The cause is probably in toolkit/modules/ShortcutUtils.sys.mjs

Comment 3

[johndiamond]

In retrospect a more appropriate component would probably be 'Toolkit::Add-ons Manager'

Comment 4

[johndiamond]

Attachment: Bug 1924542 - Support function keys up to F19 as extension shortcuts. r=rpl

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1924542 - Add test coverage for WebExtensions commands shortcuts using F1-F19 keys. r?willdurand!

Depends on D225549

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1924542 - Disallow F13-F19 when specified in the extension manifest r?willdurand!

Depends on D225549

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c619b8d2bc1
Support function keys up to F19 as extension shortcuts. r=rpl
https://hg.mozilla.org/integration/autoland/rev/fbe1421b2911
Disallow F13-F19 when specified in the extension manifest r=willdurand
https://hg.mozilla.org/integration/autoland/rev/7711a1e3e9ae
Add test coverage for WebExtensions commands shortcuts using F1-F19 keys. r=willdurand

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8c619b8d2bc1
https://hg.mozilla.org/mozilla-central/rev/fbe1421b2911
https://hg.mozilla.org/mozilla-central/rev/7711a1e3e9ae

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

A short brief summary of the changes part of this bugzilla issue for the dev-docs-needed flag:

• starting from Firefox >= 135, users will be allowed to assign to extensions commands keyboard shortcuts using the extended F13-F19 function keys
• Using extended F13-F19 function keys as suggested keyboard shortcuts assigned by default through extension manifest is still disallowed (as it was on older Firefox versions)
• The manifest validation error logged in Firefox >= 135 will be stating more explicitly that these keys can only be used for user-defined keyboard shortcuts (F13-F19 keys can only be used for user-defined keyboard shortcuts in about:addons "Manage Extension Shortcuts")
• The extensions can also try to assign F13-F19 shortcuts through the browser.commands.update API method, which will reject the keys as invalid on older Firefox version but will succeed in Firefox >= 135