1924589 - Remove getNSSErrorClass function and tidy up NSS related code in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

At the moment there are two callers for getNSSErrorClass but the second caller needs to make further use of the nss_errors_service so let's remove the helper function and just use the nss_errors_service directly within each caller's code.

Comment 1

[Ian Neal]

Attachment: 1924589-irc-tidy-nss-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: 1924589-irc-tidy-nss-v1_1-25320.patch

Check value being passed to getErrorClass is in a valid range
The other option, maybe safer one, is to use try/catch as previously.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9431429 [details] [diff] [review]
1924589-irc-tidy-nss-v1_1-25320.patch

Mozilla always seems to do the try/catch so I wonder if this shouldn't be restored instead of checking the range.
Anyweay maybe something for a followup r/a=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cb3e7f04ebec
Remove getNSSErrorClass function and tidy up NSS related code in cZ. r=frg