Closed Bug 1924592 Opened 4 months ago Closed 2 months ago

Tidy message manager code in cZ

Categories

(SeaMonkey :: Chat, task)

Product:
SeaMonkey
Component:
Chat
Type:
task

Tracking

(seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.20)

Attachments

(1 file)

1924592-irc-tidy-message-manager-25320.patch
12.03 KB, patch
frg
: review+
frg
: approval-comm-release+
Details | Diff | Splinter Review

Tidy up the code for message management:

  • Replace srGetStrBundle function with Services.strings
  • Just use branding/locale/brand.properties for the branding
  • Correct entity name from brandVendorName to vendorShortName
  • Remove convertHankakuToZenkaku function as that's now built into ConvertFromUnicode (see bug 563283)

[Approval Request Comment]
Regression caused by (bug #): bug 563283
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9430872 - Flags: review?(frgrahl)
Attachment #9430872 - Flags: approval-comm-release?
status-seamonkey2.53: --- → affected
tracking-seamonkey2.53: --- → ?
Whiteboard: SM2.53.20

Comment on attachment 9430872 [details] [diff] [review]
1924592-irc-tidy-message-manager-25320.patch

lgtm r/a+

Attachment #9430872 - Flags: review?(frgrahl)
Attachment #9430872 - Flags: review+
Attachment #9430872 - Flags: approval-comm-release?
Attachment #9430872 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/0124d1083dd6
Tidy message manager code in cZ. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: