Closed
Bug 1924595
Opened 3 months ago
Closed 2 months ago
Remove getService helper and tidy up code around its callers in cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
11.12 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
In most cases it is easier just to user Cc[CcontractID].getService(interface) rather than using the helper getService function, so let's do that.
Whilst there remove some code that is no longer required for backwards compatibility.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: one string removal
Attachment #9430874 -
Flags: review?(frgrahl)
Attachment #9430874 -
Flags: approval-comm-release?
|
||
Updated•2 months ago
|
|
|
||
Comment 2•2 months ago
|
||
Comment on attachment 9430874 [details] [diff] [review]
1924595-irc-getService-25320.patch
lgtm r/a+
Attachment #9430874 -
Flags: review?(frgrahl)
Attachment #9430874 -
Flags: review+
Attachment #9430874 -
Flags: approval-comm-release?
Attachment #9430874 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/d30eb79a8caf
Remove getService helper and tidy up code around its callers in cZ. r=frg
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•