1924608 - [Outreachy] Add non262 tests for Error.isError

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement, P3)

Description

[Dan Minor [:dminor]]

Once the initial implementation for Error.isError lands in Bug 1924202, we'll need some tests.

There's currently no tests for the Error.isError proposal in test262 because it only just reached Stage 2.7. We should add some non262 tests for now, to have some coverage for our implementation. Please add a new isError.js test file to this directory with some tests to cover basic functionality, e.g. things like:

assertEq(Error.isError(2), false);
assertEq(Error.isError(new Error()), true)

These tests can be run using ./mach jstests non262/Error.

Comment 1

[Chiemelie Carita]

Let me work on this.

Comment 2

[Serah Nderi]

(In reply to Chiemelie Carita from comment #1)

Let me work on this.

I had already been assigned this issue.

Comment 3

[Serah Nderi]

Attachment: Bug 1924608 - Add non262 tests for Error.isError; r=dminor!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9ffe12dcc8a
Add non262 tests for Error.isError; r=dminor

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a9ffe12dcc8a