1924650 - Visibility issues with install dialog “Cancel” button and optional permissions dialog “Deny” button when HCM is enabled

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alex Cornestean]

Attachment: HCM.png

Description:
When HCM is enabled in Windows and using the default HCM color schemes provided in the OS, there are several visibility issues with the install dialog “Cancel” button and the optional permissions dialog “Deny” button, as follow:

1. Using “High Contrast 1” and “High Contrast 2”, both the “Cancel” and “Deny” button strings are no longer visible when hovering the mouse over them, as these HCM color schemes both use white to highlight those buttons and the strings on the buttons are also white.
2. Using “High Contrast Black”, the buttons highlight is not visible when hovering over the buttons, as this HCM scheme uses black for highlighting and the dialog background is also black. The string on the buttons is still visible.
3. Using “High Contrast White”, the buttons highlight is not visible when hovering over the buttons, as this HCM scheme uses white for highlighting and the dialog background is also white. The string on the buttons is still visible.

This does not appear to be an issue introduced by the changes to the install and optional permissions dialogs, however due to work on these dialogs being in progress, this issue could be addressed.

For more details, see the attached screenshots.

Steps to reproduce:
A.

1. Enable “High Contrast 1” in the HCM settings pane
2. Install “Tree Style Tab”
3. On the install dialog, hover over the “Cancel” button (notice the button string is no longer visible)
4. Click on the add-on card in about:addons
5. Once in the detailed view of the add-on, click on the “Options” tab
6. Locate the “Context Menu” header
7. Click on the checkbox of “Allow to read and create bookmarks”. This will trigger the optional permissions dialog
8. On the optional permissions dialog, hover over the “Deny” button (notice the button string is no longer visible)

B.

1. Enable “High Contrast 2” in the HCM settings pane
2. Repeat Steps 2 & 3 from A. (notice the button string is no longer visible)
3. Repeat Steps 4 to 8 from A. (notice the button string is no longer visible)

C.

1. Enable “High Contrast Black” in the HCM settings pane
2. Repeat Steps 2 & 3 from A. (notice the button highlight is not visible as it’s the same color as the background)
3. Repeat Steps 4 to 8 from A. (notice the button highlight is not visible as it’s the same color as the background)

D.

1. Enable “High Contrast White” in the HCM settings pane
2. Repeat Steps 2 & 3 from A. (notice the button highlight is not visible as it’s the same color as the background)
3. Repeat Steps 4 to 8 from A. (notice the button highlight is not visible as it’s the same color as the background)

Expected:
Button strings and highlights on hover should be visible with HCM enabled

Actual:
There are visibility issues with the mentioned button strings and highlights when HCM is enabled.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

That part of the dialog is inherited from the popupnotification shared widget, and so I suspected this was regressed by some other changes and I got it narrowed to the following change by bisecting it using mozregression:

2024-10-16T04:05:46.604000: DEBUG : Found commit message:
Bug 1917588 - Stop setting  --button-bgcolor, --button-hover-bgcolor, --button-active-bgcolor in browser-shared.css. r=desktop-theme-reviewers,emilio

Differential Revision: https://phabricator.services.mozilla.com/D221480

2024-10-16T04:05:46.604000: DEBUG : Did not find a branch, checking all integration branches
2024-10-16T04:05:46.604000: INFO : The bisection is done.
2024-10-16T04:05:46.604000: INFO : Stopped

which means that the regression is in 132 beta.

dao, would you mind to take a look into this?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1917588

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1924650 - Set text color on footer buttons. r?#theme

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/942708472aad
Set text color on footer buttons. r=desktop-theme-reviewers,Itiel

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/942708472aad

Comment 6

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (133.0a1/20241016214437) under Windows 10 x64.

For the High Contrast #1 and High Contrast #2 themes, the “Cancel” and “Deny” button strings are now visible on hovering the cursor over them.

For the High Contrast Black and High Contrast White themes, the “Cancel” and “Deny” button strings now change color when hovering over them, indicating that the cursor is indeed on top of the buttons.

See the attached screenshots for more details.

Comment 7

[Alex Cornestean]

Attachment: HCM fixed.png

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9431215 [details]
Bug 1924650 - Set text color on footer buttons. r?#theme

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9431215 [details]
Bug 1924650 - Set text color on footer buttons. r?#theme

Approved for 132.0b9.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/62f1d96185e3

Comment 12

[Alex Cornestean]

Verified as Fixed. Tested on the latest Beta (132.0b9/20241017123117 from https://treeherder.mozilla.org/jobs?repo=mozilla-beta&revision=99cac520516b80dc2889fa6ea9915ea521129dde) under Windows 10 x64.

For the High Contrast #1 and High Contrast #2 themes, the “Cancel” and “Deny” button strings are now visible on hovering the cursor over them.

For the High Contrast Black and High Contrast White themes, the “Cancel” and “Deny” button strings now change color when hovering over them with the cursor, indicating that the cursor is indeed on top of the button.

For more details, see the attachment in Comment 7 as both the Nightly and Beta dialogs look the same under these circumstances.