1924702 - When using adwaita in KDE, we end up using a darker color, which looks off

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Screenshot of a checkbox, but also affects selection text etc.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1924702 - Lower a bit WCAG min contrast ratio for white foreground. r=ayeddi!

With the current WCAG algorithm, we end up choosing suboptimal colors
for accent colors like Breeze's (which is a common style in Linux).

Breeze accent color is #3daee9. System UI uses white on top of it. Its
contrast with white is 2.49 (WCAG-wise), so we fall back to a darkened
color, which gets a much better WCAG ratio, but not so great visual
result.

Realistically we do want to use white for this color, it does look a lot
better and it does get more (perceptual) contrast that the color we come
up with which is rgb(0, 47, 86).

Lower the threshold a little bit. We should experiment with using APCA
or so for this calculation (for which black and white get very similar
contrast ratios for this accent color), but for now this doesn't cause
illegible checkboxes in https://accent-color.glitch.me/, and seems like
a net improvement for these "in-between" kinds of colors.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1922872

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba2cec2237d6
Lower a bit WCAG min contrast ratio for white foreground. r=ayeddi

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ba2cec2237d6