Closed
Bug 1924848
Opened 28 days ago
Closed 18 days ago
pageActionInUrlbar trigger doesn't have the right wait for ASRouter
Categories
(Firefox :: Messaging System, defect, P2)
Firefox
Messaging System
Tracking
()
RESOLVED
FIXED
133 Branch
| Tracking | Status | |
|---|---|---|
| firefox133 | --- | fixed |
People
(Reporter: aminomancer, Assigned: emcminn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
await lazy.ASRouter.initialized;
This property is actually just a boolean. The one we actually want to await is ASRouter.waitForInitialized. Alternatively, we might want to just change this to a boolean check if (lazy.ASRouter.initialized) ... but I'm not sure about that. I'd leave it up to the engineer who works on this.
This isn't currently causing any problems, but the code is technically wrong. So I'd recommend P3 priority, S4 severity.
|
Reporter | |
Updated•22 days ago
|
Points: --- → 1
Priority: -- → P2
|
Assignee | |
Comment 1•20 days ago
|
||
|
||
Updated•20 days ago
|
Assignee: nobody → emcminn
Status: NEW → ASSIGNED
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/670f8e6844ab
Use the correct await in sendPlacedInUrlbarTrigger r=omc-reviewers,aminomancer
|
||
Comment 3•18 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 18 days ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•