1924861 - User Interaction Tracking should be considered for initial history entries

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Adam Vandolder [:avandolder]]

Currently, we always treat the initial entry in a history list as though it had been interacted with by the user. However, this may not always be true, and could potentially result in a back-button "trap" where the user attempts to go back but gets immediately redirected by a page they have not interacted with.

Comment 1

[Adam Vandolder [:avandolder]]

Attachment: Bug 1924861 - Only show the first history entry if it has user interaction. r?#dom-core

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b4cea7ea948
Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/758535590e5d
Backed out changeset 5b4cea7ea948 for causing mochitest failures on test_ext_tabs_goBack_goForward.html, test_bug1300461.html CLOSED TREE

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on test_ext_tabs_goBack_goForward.html, test_bug1300461.html

Backout link

Push with failures

Failure log // Failure log 2

There are also some Search related failures present, this and this one, which seem to have apperead once this push landed. Here is a backfill range example. The logs for the failures are the following: Failure log 1 // Failure log 2

This failure is also caused by this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c64aebba09d9
Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/99a85d68bb2a1a554f246466d3ebd1adb8d8a530

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | docshell/test/navigation/test_bug1300461.html | check canGoBack

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c5bff1fa41a
Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster

Comment 8

[Atila Butkovits]

Backed out for causing failures at forward.py.

Backout link: https://hg.mozilla.org/integration/autoland/rev/46a9261a972da3064456c9ed596efb1da36dcc9b

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=337d4c8f793e8f4ef5a8efbca1f9d02edb56b409&selectedTaskRun=ViUIyy6uTReBZstxA5qVBg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=484188640&repo=autoland&lineNumber=49662

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b94afd94ed9c
Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b94afd94ed9c

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing multiple bc failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/51087836c42d78ed0458de5e3b9824127263efdc

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/zoom/browser_background_zoom.js | Test timed out

Failure log -> TEST-UNEXPECTED-FAIL | docshell/test/browser/browser_bug422543.js | we can go back

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8d030efc4ea
Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers

Comment 13

[Cosmin Sabou [:CosminS]]

Backed out changeset a8d030efc4ea (Bug 1924861) for causing bc failures on browser_stop_pending.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a8d030efc4ea7a7337d1aa624ed99995681256e6&selectedTaskRun=drUwnYlsR0eX5XIfOZ9kVA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=484887625&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/ca74bdc3b83dad25744b52c2ad8ee057b1f2dc38

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d19e4620e63
Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers

Comment 15

[agoloman]

Backed out for causing bc failures @browser_stop_pending.js.

• Backout link
• Push with failures
• Failure Log

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9642ea5c42d0
Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers

Comment 17

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9642ea5c42d0