1925014 - Disable HTTP/3 if third party roots found

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P1)

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1925014 - Disallow HTTP/3 when third party root is found, r=#necko

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1925014 - Test case, r=#necko

Depends on D225788

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/548b916ef37d
Disallow HTTP/3 when third party root is found, r=necko-reviewers,keeler,valentin
https://hg.mozilla.org/integration/autoland/rev/197f9b5798d6
Test case, r=necko-reviewers,valentin

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Bug 1925014 - Add network.http.http3.disable_when_third_party_roots_found to nimbus manifest, r=#necko

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/548b916ef37d
https://hg.mozilla.org/mozilla-central/rev/197f9b5798d6

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing perma android xpc failures @ test_http3.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8b5468f905c3ac74a70c2a785442291a3533b98f

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_http3.js

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5df6b73dcb6c
Disallow HTTP/3 when third party root is found, r=necko-reviewers,keeler,valentin
https://hg.mozilla.org/integration/autoland/rev/15c56a7463ec
Test case, r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/e09635a1801e
Add network.http.http3.disable_when_third_party_roots_found to nimbus manifest, r=necko-reviewers,valentin

Comment 8

[agoloman]

Backed out for causing xpcshell fails @ test_http3.js.

• Backout link
• Push with failures
• Failure Log
• Failure line:

task 2024-10-18T12:08:59.451Z] 12:08:59     INFO -  TEST-START | netwerk/test/unit/test_http3.js
[task 2024-10-18T12:08:59.492Z] 12:08:59     INFO -  adb launch_application: am startservice -W -n 'org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.XpcshellTestRunnerService$i0' -a android.intent.action.MAIN --es env0 XPCOM_DEBUG_BREAK=stack-and-abort --es env1 MOZ_CRASHREPORTER=1 --es env2 MOZ_CRASHREPORTER_NO_REPORT=1 --es env3 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env4 MOZ_DEVELOPER_REPO_DIR=/builds/worker/checkouts/gecko --es env5 MOZ_DEVELOPER_OBJ_DIR=/builds/worker/workspace/obj-build --es env6 MOZ_DISABLE_CONTENT_SANDBOX=1 --es env7 MOZ_FETCHES_DIR=/builds/worker/fetches --es env8 MOZ_DISABLE_SOCKET_PROCESS=1 --es env9 LD_LIBRARY_PATH=/data/local/tmp/test_root/xpcb --es env10 MOZ_LINKER_CACHE=/data/local/tmp/test_root/xpcb --es env11 GRE_HOME=/data/local/tmp/test_root/xpcb --es env12 XPCSHELL_TEST_PROFILE_DIR=/data/local/tmp/test_root/xpc/p/2d5f1807-b712-4561-9a0e-23dc2f8ef727 --es env13 HOME=/data/local/tmp/test_root/xpc/p --es env14 XPCSHELL_TEST_TEMP_DIR=/data/local/tmp/test_root/xpc/tmp/e7e2ca83-77a9-4e6b-abff-1310ef072678 --es env15 MOZ_ANDROID_DATA_DIR=/data/local/tmp/test_root/xpcb --es env16 MOZ_IN_AUTOMATION=1 --es env17 MOZ_ANDROID_CPU_ABI=x86_64 --es env18 MOZHTTP2_PORT=44002 --es env19 MOZNODE_EXEC_PORT=41873 --es env20 MOZHTTP3_PORT=56232 --es env21 MOZHTTP3_PORT_FAILED=52629 --es env22 MOZHTTP3_PORT_ECH=51314 --es env23 MOZHTTP3_PORT_PROXY=36900 --es env24 MOZHTTP3_PORT_NO_RESPONSE=53800 --es env25 MOZHTTP3_ECH=AE3+DQBJBwAgACCB3RaFBNPvHyoYeKMk9ibqlu+uVilMN2/qDAKWvgQXBgAQAAEAAQABAAMAAgABAAIAA0AOcHVibGljLmV4YW1wbGUAAA== --es env26 MOZ_HTTP3_SERVER_PATH=/builds/worker/fetches/hostutils/http3server --es env27 MOZ_HTTP3_CERT_DB_PATH=/builds/worker/workspace/build/tests/xpcshell/http3server/http3serverDB --es env28 TMPDIR=/data/local/tmp/test_root/xpc/p/2d5f1807-b712-4561-9a0e-23dc2f8ef727 --es env29 XPCSHELL_MINIDUMP_DIR=/data/local/tmp/test_root/xpc/minidumps/2d5f1807-b712-4561-9a0e-23dc2f8ef727 --es arg0 -g --es arg1 /data/local/tmp/test_root/xpcb --es arg2 --greomni --es arg3 /data/local/tmp/test_root/xpcb/geckoview-test_runner.apk --es arg4 -m --es arg5 -e --es arg6 'const _HEAD_JS_PATH = "/data/local/tmp/test_root/xpc/head.js";' --es arg7 -e --es arg8 'const _MOZINFO_JS_PATH = "/data/local/tmp/test_root/xpc/p/2d5f1807-b712-4561-9a0e-23dc2f8ef727/mozinfo.json";' --es arg9 -e --es arg10 'const _PREFS_FILE = "/data/local/tmp/test_root/xpc/tmp/e7e2ca83-77a9-4e6b-abff-1310ef072678/user.js";' --es arg11 -e --es arg12 'const _TESTING_MODULES_DIR = "/data/local/tmp/test_root/xpc/m";' --es arg13 -f --es arg14 /data/local/tmp/test_root/xpc/head.js --es arg15 -e --es arg16 'const _HEAD_FILES = ["/data/local/tmp/test_root/xpc/netwerk/test/unit/head_channels.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_cache.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_cache2.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_cookies.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_servers.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_trr.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_http3.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_telemetry.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_websocket.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_webtransport.js"];' --es arg17 -e --es arg18 'const _JSDEBUGGER_PORT = 0;' --es arg19 -e --es arg20 'const _TEST_CWD = "/data/local/tmp/test_root/xpc/netwerk/test/unit";' --es arg21 -e --es arg22 'const _TEST_FILE = ["test_http3.js"];' --es arg23 -e --es arg24 'const _TEST_NAME = "netwerk/test/unit/test_http3.js";' --es arg25 -e --es arg26 '_execute_test(); quit(0);' --es out_file /data/local/tmp/test_root/xpc/logs/xpcshell-bc611b73-d5a1-420d-810d-167e7df0db2e.log
[task 2024-10-18T12:08:59.702Z] 12:08:59     INFO -  remotexpcshelltests.py | netwerk/test/unit/test_http3.js | 19856 | Launched Test App
[task 2024-10-18T12:09:00.757Z] 12:09:00     INFO -  remotexpcshelltests.py | netwerk/test/unit/test_http3.js | 19856 | Application ran for: 0:00:01.305148
[task 2024-10-18T12:09:00.821Z] 12:09:00  WARNING -  TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_http3.js | xpcshell return code: 0
[task 2024-10-18T12:09:00.821Z] 12:09:00     INFO -  TEST-INFO took 1369ms
[task 2024-10-18T12:09:00.821Z] 12:09:00     INFO -  >>>>>>>
[task 2024-10-18T12:09:00.821Z] 12:09:00     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-10-18T12:09:00.821Z] 12:09:00     INFO -  TEST-PASS | netwerk/test/unit/test_http3.js | run_test - [run_test : 63] "44002" != null

Comment 9

[Kershaw Chang [:kershaw]]

(In reply to agoloman from comment #8)

Backed out for causing xpcshell fails @ test_http3.js.

• Backout link
• Push with failures
• Failure Log
• Failure line:

task 2024-10-18T12:08:59.451Z] 12:08:59     INFO -  TEST-START | netwerk/test/unit/test_http3.js
[task 2024-10-18T12:08:59.492Z] 12:08:59     INFO -  adb launch_application: am startservice -W -n 'org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.XpcshellTestRunnerService$i0' -a android.intent.action.MAIN --es env0 XPCOM_DEBUG_BREAK=stack-and-abort --es env1 MOZ_CRASHREPORTER=1 --es env2 MOZ_CRASHREPORTER_NO_REPORT=1 --es env3 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env4 MOZ_DEVELOPER_REPO_DIR=/builds/worker/checkouts/gecko --es env5 MOZ_DEVELOPER_OBJ_DIR=/builds/worker/workspace/obj-build --es env6 MOZ_DISABLE_CONTENT_SANDBOX=1 --es env7 MOZ_FETCHES_DIR=/builds/worker/fetches --es env8 MOZ_DISABLE_SOCKET_PROCESS=1 --es env9 LD_LIBRARY_PATH=/data/local/tmp/test_root/xpcb --es env10 MOZ_LINKER_CACHE=/data/local/tmp/test_root/xpcb --es env11 GRE_HOME=/data/local/tmp/test_root/xpcb --es env12 XPCSHELL_TEST_PROFILE_DIR=/data/local/tmp/test_root/xpc/p/2d5f1807-b712-4561-9a0e-23dc2f8ef727 --es env13 HOME=/data/local/tmp/test_root/xpc/p --es env14 XPCSHELL_TEST_TEMP_DIR=/data/local/tmp/test_root/xpc/tmp/e7e2ca83-77a9-4e6b-abff-1310ef072678 --es env15 MOZ_ANDROID_DATA_DIR=/data/local/tmp/test_root/xpcb --es env16 MOZ_IN_AUTOMATION=1 --es env17 MOZ_ANDROID_CPU_ABI=x86_64 --es env18 MOZHTTP2_PORT=44002 --es env19 MOZNODE_EXEC_PORT=41873 --es env20 MOZHTTP3_PORT=56232 --es env21 MOZHTTP3_PORT_FAILED=52629 --es env22 MOZHTTP3_PORT_ECH=51314 --es env23 MOZHTTP3_PORT_PROXY=36900 --es env24 MOZHTTP3_PORT_NO_RESPONSE=53800 --es env25 MOZHTTP3_ECH=AE3+DQBJBwAgACCB3RaFBNPvHyoYeKMk9ibqlu+uVilMN2/qDAKWvgQXBgAQAAEAAQABAAMAAgABAAIAA0AOcHVibGljLmV4YW1wbGUAAA== --es env26 MOZ_HTTP3_SERVER_PATH=/builds/worker/fetches/hostutils/http3server --es env27 MOZ_HTTP3_CERT_DB_PATH=/builds/worker/workspace/build/tests/xpcshell/http3server/http3serverDB --es env28 TMPDIR=/data/local/tmp/test_root/xpc/p/2d5f1807-b712-4561-9a0e-23dc2f8ef727 --es env29 XPCSHELL_MINIDUMP_DIR=/data/local/tmp/test_root/xpc/minidumps/2d5f1807-b712-4561-9a0e-23dc2f8ef727 --es arg0 -g --es arg1 /data/local/tmp/test_root/xpcb --es arg2 --greomni --es arg3 /data/local/tmp/test_root/xpcb/geckoview-test_runner.apk --es arg4 -m --es arg5 -e --es arg6 'const _HEAD_JS_PATH = "/data/local/tmp/test_root/xpc/head.js";' --es arg7 -e --es arg8 'const _MOZINFO_JS_PATH = "/data/local/tmp/test_root/xpc/p/2d5f1807-b712-4561-9a0e-23dc2f8ef727/mozinfo.json";' --es arg9 -e --es arg10 'const _PREFS_FILE = "/data/local/tmp/test_root/xpc/tmp/e7e2ca83-77a9-4e6b-abff-1310ef072678/user.js";' --es arg11 -e --es arg12 'const _TESTING_MODULES_DIR = "/data/local/tmp/test_root/xpc/m";' --es arg13 -f --es arg14 /data/local/tmp/test_root/xpc/head.js --es arg15 -e --es arg16 'const _HEAD_FILES = ["/data/local/tmp/test_root/xpc/netwerk/test/unit/head_channels.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_cache.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_cache2.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_cookies.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_servers.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_trr.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_http3.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_telemetry.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_websocket.js", "/data/local/tmp/test_root/xpc/netwerk/test/unit/head_webtransport.js"];' --es arg17 -e --es arg18 'const _JSDEBUGGER_PORT = 0;' --es arg19 -e --es arg20 'const _TEST_CWD = "/data/local/tmp/test_root/xpc/netwerk/test/unit";' --es arg21 -e --es arg22 'const _TEST_FILE = ["test_http3.js"];' --es arg23 -e --es arg24 'const _TEST_NAME = "netwerk/test/unit/test_http3.js";' --es arg25 -e --es arg26 '_execute_test(); quit(0);' --es out_file /data/local/tmp/test_root/xpc/logs/xpcshell-bc611b73-d5a1-420d-810d-167e7df0db2e.log
[task 2024-10-18T12:08:59.702Z] 12:08:59     INFO -  remotexpcshelltests.py | netwerk/test/unit/test_http3.js | 19856 | Launched Test App
[task 2024-10-18T12:09:00.757Z] 12:09:00     INFO -  remotexpcshelltests.py | netwerk/test/unit/test_http3.js | 19856 | Application ran for: 0:00:01.305148
[task 2024-10-18T12:09:00.821Z] 12:09:00  WARNING -  TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_http3.js | xpcshell return code: 0
[task 2024-10-18T12:09:00.821Z] 12:09:00     INFO -  TEST-INFO took 1369ms
[task 2024-10-18T12:09:00.821Z] 12:09:00     INFO -  >>>>>>>
[task 2024-10-18T12:09:00.821Z] 12:09:00     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-10-18T12:09:00.821Z] 12:09:00     INFO -  TEST-PASS | netwerk/test/unit/test_http3.js | run_test - [run_test : 63] "44002" != null

Not sure why this affects HTTP/3 tests on Android. I'll disable this feature for Android for now and investigate later.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e7b2c342d1b
Disallow HTTP/3 when third party root is found, r=necko-reviewers,keeler,valentin
https://hg.mozilla.org/integration/autoland/rev/2a475116b284
Test case, r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/95383315efe9
Add network.http.http3.disable_when_third_party_roots_found to nimbus manifest, r=necko-reviewers,valentin

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8e7b2c342d1b
https://hg.mozilla.org/mozilla-central/rev/2a475116b284
https://hg.mozilla.org/mozilla-central/rev/95383315efe9

Comment 12

[Kershaw Chang [:kershaw]]

Attachment: Bug 1925014 - Disallow HTTP/3 when third party root is found.

Comment 13

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: There is no impact because this feature is disabled. This patch is intended to be used only if an HTTP/3 connection is interrupted by Avast again.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low.
• Explanation of risk level: Low risk, becasue this feature is disabled.
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2b2f9bab00b9