Closed
Bug 1925033
Opened 3 months ago
Closed 3 months ago
Use Services.focus for bookmarking from mailnews in SeaMonkey
Categories
(SeaMonkey :: Bookmarks & History, enhancement)
SeaMonkey
Bookmarks & History
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: frg, Assigned: frg)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
1.71 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
|
Details | Diff | Splinter Review |
We use a lazy service getter for the Windows focus maager in PlacesUIUtils.jsm. This can be simplified using a services call.
|
Assignee | |
Comment 1•3 months ago
|
||
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20b1pre
Risk to taking this patch (and alternatives if risky): trivial replacement
String changes made by this patch: --
Attachment #9431260 -
Flags: review?(iannbugzilla)
Attachment #9431260 -
Flags: approval-comm-release?
Comment on attachment 9431260 [details] [diff] [review]
1925033-focus-25320.patch
[Triage Comment]
LGTM r/a=me
Attachment #9431260 -
Flags: review?(iannbugzilla)
Attachment #9431260 -
Flags: review+
Attachment #9431260 -
Flags: approval-comm-release?
Attachment #9431260 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/0e3bdb70dd76
Use Services.focus for bookmarking from mailnews. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•