Closed
Bug 192513
Opened 21 years ago
Closed 21 years ago
processmail as a package cleanup
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: justdave, Assigned: justdave)
Details
(Keywords: regression)
Attachments
(2 files, 2 obsolete files)
1.32 KB,
patch
|
justdave
:
review+
|
Details | Diff | Splinter Review |
4.31 KB,
patch
|
preed
:
review+
|
Details | Diff | Splinter Review |
move.pl and importxml.pl both call processmail, which no longer exists. They need to be changed to use Bugzilla::BugMail.
Assignee | ||
Updated•21 years ago
|
Target Milestone: --- → Bugzilla 2.18
Assignee | ||
Comment 1•21 years ago
|
||
OK, the problem is bigger than just importxml.pl and move.pl :) dave@landfill [17:30 bugzilla-tip 26] tcsh# grep -r -n 'processmail' * | egrep -v '^docs' | egrep -v '^contrib' checksetup.pl:824:<FilesMatch ^(.*\.pl|.*localconfig.*|processmail|runtests.sh)$> checksetup.pl:1110:my @executable_files = ('processmail', 'whineatnews.pl', 'collectstats.pl', importxml.pl:651: system("./processmail", $id, $exporter); move.pl:135: system("./processmail", $id, $exporter); post_bug.cgi:208:# and the list for passing to processmail process_bug.cgi:1401: # We need to run processmail for dependson/blocked bugs if the dependencies process_bug.cgi:1589: # for passing to processmail to ensure that when someone is removed process_bug.cgi:1615: # save off the old value for passing to processmail so the old t/Support/Files.pm:29:@additional_files = ('syncshadowdb','processmail'); t/002goodperl.t:55: if ($file eq "processmail") { t/002goodperl.t:56: # special case processmail, which is tainted checked
Summary: move.pl and importxml.pl both call processmail, which no longer exists → processmail as a package cleanup
Assignee | ||
Comment 2•21 years ago
|
||
CCing Zach since there's test-related stuff in here.
Comment 3•21 years ago
|
||
This should remove all the processmail goup from the tests
Updated•21 years ago
|
Attachment #113981 -
Flags: review?
Assignee | ||
Comment 4•21 years ago
|
||
Comment on attachment 113981 [details] [diff] [review] Remove the processmail components from the tests while we're at it, synchshadowdb doesn't exist anymore, either.
Attachment #113981 -
Flags: review? → review-
Comment 5•21 years ago
|
||
Attachment #113981 -
Attachment is obsolete: true
Assignee | ||
Comment 6•21 years ago
|
||
Comment on attachment 113982 [details] [diff] [review] v2, I just can't win ok, this works. Go ahead and check this in, and note here that you've done so, but don't resolve the bug. We have the rest of the stuff to kill off still.
Attachment #113982 -
Flags: review+
Comment 7•21 years ago
|
||
Patch checked in, not marking the bug fixed since that it only one component of the problem
Assignee | ||
Comment 8•21 years ago
|
||
This fixes everything except for the tests, which were covered by Zach's patch which is already checked in.
Assignee | ||
Updated•21 years ago
|
Attachment #113985 -
Flags: review?(preed)
Comment 9•21 years ago
|
||
Comment on attachment 113985 [details] [diff] [review] Everything else >- # for passing to processmail to ensure that when someone is removed >+ # for passing to the mail routines to ensure that when someone is removed >+ # save off the old value for passing to the mail routines so >+ # the old owner can be notified Nit: instead of "the mail routines," name the routine or at least the module. Other than that, r=preed.
Attachment #113985 -
Flags: review?(preed) → review+
Assignee | ||
Comment 10•21 years ago
|
||
Attachment #113985 -
Attachment is obsolete: true
Comment 11•21 years ago
|
||
Comment on attachment 113986 [details] [diff] [review] patch v2, fixes nits Looks good; check this bad boy in! :-)
Attachment #113986 -
Flags: review+
Assignee | ||
Comment 12•21 years ago
|
||
Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.220; previous revision: 1.219 done Checking in importxml.pl; /cvsroot/mozilla/webtools/bugzilla/importxml.pl,v <-- importxml.pl new revision: 1.30; previous revision: 1.29 done Checking in move.pl; /cvsroot/mozilla/webtools/bugzilla/move.pl,v <-- move.pl new revision: 1.18; previous revision: 1.17 done Checking in post_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v <-- post_bug.cgi new revision: 1.79; previous revision: 1.78 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.176; previous revision: 1.175 done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•