192513 - processmail as a package cleanup

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Dave Miller [:justdave]]

move.pl and importxml.pl both call processmail, which no longer exists.  They
need to be changed to use Bugzilla::BugMail.

Comment 1

[Dave Miller [:justdave]]

OK, the problem is bigger than just importxml.pl and move.pl :)

dave@landfill [17:30 bugzilla-tip 26] tcsh# grep -r -n 'processmail' * | egrep
-v '^docs' | egrep -v '^contrib'
checksetup.pl:824:<FilesMatch ^(.*\.pl|.*localconfig.*|processmail|runtests.sh)$>
checksetup.pl:1110:my @executable_files = ('processmail', 'whineatnews.pl',
'collectstats.pl',
importxml.pl:651:  system("./processmail", $id, $exporter);
move.pl:135:    system("./processmail", $id, $exporter);
post_bug.cgi:208:# and the list for passing to processmail
process_bug.cgi:1401:    # We need to run processmail for dependson/blocked bugs
if the dependencies
process_bug.cgi:1589:    # for passing to processmail to ensure that when
someone is removed
process_bug.cgi:1615:            # save off the old value for passing to
processmail so the old
t/Support/Files.pm:29:@additional_files = ('syncshadowdb','processmail');
t/002goodperl.t:55:        if ($file eq "processmail") {
t/002goodperl.t:56:            # special case processmail, which is tainted checked

Comment 2

[Dave Miller [:justdave]]

CCing Zach since there's test-related stuff in here.

Comment 3

[Zach Lipton [:zach]]

Attachment: Remove the processmail components from the tests

This should remove all the processmail goup from the tests

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 113981 [details] [diff] [review]
Remove the processmail components from the tests

while we're at it, synchshadowdb doesn't exist anymore, either.

Comment 5

[Zach Lipton [:zach]]

Attachment: v2, I just can't win

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 113982 [details] [diff] [review]
v2, I just can't win

ok, this works.  Go ahead and check this in, and note here that you've done so,
but don't resolve the bug.  We have the rest of the stuff to kill off still.

Comment 7

[Zach Lipton [:zach]]

Patch checked in, not marking the bug fixed since that it only one component of
the problem

Comment 8

[Dave Miller [:justdave]]

Attachment: Everything else

This fixes everything except for the tests, which were covered by Zach's patch
which is already checked in.

Comment 9

[J. Paul Reed [:preed]]

Comment on attachment 113985 [details] [diff] [review]
Everything else


>-    # for passing to processmail to ensure that when someone is removed
>+    # for passing to the mail routines to ensure that when someone is removed

>+            # save off the old value for passing to the mail routines so
>+            # the old owner can be notified

Nit: instead of "the mail routines," name the routine or at least the module.

Other than that, r=preed.

Comment 10

[Dave Miller [:justdave]]

Attachment: patch v2, fixes nits

Comment 11

[J. Paul Reed [:preed]]

Comment on attachment 113986 [details] [diff] [review]
patch v2, fixes nits

Looks good; check this bad boy in! :-)

Comment 12

[Dave Miller [:justdave]]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.220; previous revision: 1.219
done
Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.30; previous revision: 1.29
done
Checking in move.pl;
/cvsroot/mozilla/webtools/bugzilla/move.pl,v  <--  move.pl
new revision: 1.18; previous revision: 1.17
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.79; previous revision: 1.78
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.176; previous revision: 1.175
done