1925235 - Searchmode defaults to Google after browser restart

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: bug.mov

Notes

• Reproducible when entering searchmode for Bookmarks, Tabs, Actions and History options.

Found in

• Nightly 133.0a1;

Affected versions

• Nightly 133.0a1;

Affected platforms

• Ubuntu 22;
• macOS 14;
• Windows 10;

Preconditions

• Have browser.urlbar.scotchBonnet.enableOverride set to true
• Have browser.urlbar.searchRestrictKeywords.featureGate set to true

Steps to reproduce

1. Launch Firefox and open a new tab.
2. From the Dedicated Search Button select Bookmarks.
3. Restart Firefox.
4. Observe the address bar.

Expected result

• Searchmode is enabled for Bookmarks.

Actual result

• Searchmode is enabled for Google.

Regression range

• Not a regression.

Comment 1

[Yazan Al Macki [:yazan]]

Attachment: WIP: Bug 1925235 - Searchmode defaults to Google after browser restart

Comment 2

[Yazan Al Macki [:yazan]]

Attachment: Bug 1925235 - Prevent search mode switcher icon from defaulting to Google on restart. r?#urlbar-reviewers

Comment 3

[Yazan Al Macki [:yazan]]

Attachment: Bug 1925235 - Avoid updating unified search button icon if searchMode has changed. r?daleharvey

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f05807fed9ba
Avoid updating unified search button icon if searchMode has changed. r=daleharvey,sessionstore-reviewers,dao

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f05807fed9ba

Comment 6

[Yazan Al Macki [:yazan]]

Attachment: Bug 1925235 - Avoid updating unified search button icon if searchMode has changed. r?daleharvey

Currently, multiple calls to #updateSearchIcon can run concurrently. When restarting the browser with a tab , and another tab in which a local search mode is active, the local search mode is incorrectly displayed as the default engine search mode. I believe this is due to the first #updateSearchIcon call (default engine, triggered when new tab is reopened) taking longer than the subsequent #updateSearchIcon call (triggered when the search mode is restored).

This is probably due to [[ https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/browser/components/urlbar/SearchModeSwitcher.sys.mjs#329-334 | this ]] code taking a while to execute in comparison to [[ https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/browser/components/urlbar/SearchModeSwitcher.sys.mjs#338-342 | this ]] code that runs for local search modes.

Ensuring that an #updateSearchIcon call terminates if search mode switches during its async processing prevents it from interfering with the next call triggered and incorrectly overriding the icon.

Original Revision: https://phabricator.services.mozilla.com/D233036

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users could see incorrect search mode icon when restarting browser, causing confusion
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Open a 2nd tab on browser and change search mode to bookmarks (with scotch bonnnet enabled). Restart the browser and observe search mode icon/label. It should display bookmarks.
• Risk associated with taking this patch: Low
• Explanation of risk level: Patch avoids updating icon when search mode changes during the update call. It's a very small fix so the risk is low.
• String changes made/needed: N/A
• Is Android affected?: no

Comment 8

[Yazan Al Macki [:yazan]]

Attachment: Bug 1925235 - Avoid updating unified search button icon if searchMode has changed.

Currently, multiple calls to #updateSearchIcon can run concurrently. When restarting the browser with a tab , and another tab in which a local search mode is active, the local search mode is incorrectly displayed as the default engine search mode. I believe this is due to the first #updateSearchIcon call (default engine, triggered when new tab is reopened) taking longer than the subsequent #updateSearchIcon call (triggered when the search mode is restored).

This is probably due to [[ https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/browser/components/urlbar/SearchModeSwitcher.sys.mjs#329-334 | this ]] code taking a while to execute in comparison to [[ https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/browser/components/urlbar/SearchModeSwitcher.sys.mjs#338-342 | this ]] code that runs for local search modes.

Ensuring that an #updateSearchIcon call terminates if search mode switches during its async processing prevents it from interfering with the next call triggered and incorrectly overriding the icon.

Original Revision: https://phabricator.services.mozilla.com/D233036

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users could see incorrect search mode icon when restarting browser, causing confusion
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Open a 2nd tab on browser and change search mode to bookmarks (with scotch bonnnet enabled). Restart the browser and observe search mode icon/label. It should display bookmarks.
• Risk associated with taking this patch: Low
• Explanation of risk level: Patch avoids updating icon when search mode changes during the update call. It's a very small fix so the risk is low.
• String changes made/needed: N/A
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6d4a4cfa83a4

Comment 11

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-10-17 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 136.0a1 and Firefox 135.0b6 ( treeherder build) on Windows 10, Ubuntu 22, macOS 14.