Open Bug 1925272 Opened 9 days ago Updated 9 hours ago

[geckodriver] Do not decode and create a file from "addon" field when sending "Addon:Install" command

Categories

(Testing :: geckodriver, task, P2)

task
Points:
3

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: Sasha, Assigned: Sasha)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [webdriver:m13])

Attachments

(1 file)

While working on bug 1806135, I've noticed that when sending Addon:Install with addon property containing the base64 representation, geckodriver creates a local file, which is not accessible when a browser is running on an Android device. Similar to what we do for profiles, in case of working with Android we have to push created files to the actual device.

Points: --- → 3
Priority: -- → P2
Whiteboard: [webdriver:m13]
Assignee: nobody → aborovova
Status: NEW → ASSIGNED

We decided that for add-on installation command to make it easier later to support WebDriver BiDi we should actually not decode addon field and create a file on the geckodriver side (since BiDi doesn't use geckodriver), we should rather just forward the field as it is and have all required logic in the shared module. So repurposing the bug for this.

Summary: [geckodriver] Push addon file created from base64 string to android device → [geckodriver] Do not decode and create a file from "addon" field when sending "Addon:Install" command
Blocks: 1927172
No longer blocks: 1806135
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: