1925272 - [geckodriver] Do not decode and create a file from "addon" field when sending "Addon:Install" command

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P3)

Description

[Alexandra Borovova [:Sasha]]

While working on bug 1806135, I've noticed that when sending Addon:Install with addon property containing the base64 representation, geckodriver creates a local file, which is not accessible when a browser is running on an Android device. Similar to what we do for profiles, in case of working with Android we have to push created files to the actual device.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1925272 - [geckodriver] Do not decode and create a file from "addon" field when sending "Addon:Install" command

Comment 2

[Alexandra Borovova [:Sasha]]

We decided that for add-on installation command to make it easier later to support WebDriver BiDi we should actually not decode addon field and create a file on the geckodriver side (since BiDi doesn't use geckodriver), we should rather just forward the field as it is and have all required logic in the shared module. So repurposing the bug for this.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

During the review process it turned out that we cannot do such a change right now to not loose backward compatibility. We basically need bug 1927172 landed first, and then wait for it to be available in the next 140 ESR release.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We have to wait with the patch on this bug until we no longer support Firefox 128. This will basically be the case when Firefox 143 gets released which is around early September 2026.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We extended the support for 115 ESR until March 2026. So we should still wait a little bit longer.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Firefox 115.33.0 (the last 115 ESR release) will be released on February 24th. This means that we no longer have to ship geckodriver with 115 support and can now finally remove this related code.

Sasha, can you please check if it still applies?

Comment 7

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1925272 - [geckodriver] Stop creating addon files when installing an addon from base64 string.

Comment 8

[Alexandra Borovova [:Sasha]]

I've created a new patch, the old patch doesn't make much sense anymore.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2f43b3c24d30
https://hg.mozilla.org/integration/autoland/rev/a4f4873424d4
[geckodriver] Stop creating addon files when installing an addon from base64 string. r=geckodriver-reviewers,whimboo

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a4f4873424d4