1925274 - Valgrind reporting leaks within ForkedChildProcessInit

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[:gerard-majax]

https://treeherder.mozilla.org/logviewer?job_id=478658260&repo=autoland&lineNumber=129869

TEST-UNEXPECTED-FAIL | valgrind-test | 203 bytes in 18 blocks are definitely lost at malloc / strdup / ForkedChildProcessInit / mozilla::ipc::ForkServer::OnMessageReceived

TEST-UNEXPECTED-FAIL | valgrind-test | 339 (200 direct, 139 indirect) bytes in 1 blocks are definitely lost at malloc / moz_xmalloc / operator / ForkedChildProcessInit

We new / strdup for argv, so it sounds like something we want, similar to bug 1878213

Comment 1

[:gerard-majax]

Attachment: Bug 1925274 - Suppress valgrind new suspected leaks related to ForkServer argv handling r?jld!

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1440207

Comment 3

[:gerard-majax]

https://treeherder.mozilla.org/jobs?repo=try&revision=9a4bbdd524e7cf89c91231de04d521e6c012dc34

Comment 4

[:gerard-majax]

https://treeherder.mozilla.org/jobs?repo=try&revision=1c2ac6514506ff8e549ce646c20150dfdf3df6e2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9896c8962cb
Suppress valgrind new suspected leaks related to ForkServer argv handling r=jld

Comment 6

[Atila Butkovits]

Backed out for causing failures at Sandbox.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/29f4b90ad4d88cea4bf520db602bc2726d921690

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ce21382483196b42fb41d78e79a565a5082dec3e&selectedTaskRun=I2LmWl9wScSrDC0JIqU_xQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=479026804&repo=autoland&lineNumber=8269

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ba9c32711af
Suppress valgrind new suspected leaks related to ForkServer argv handling r=jld

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7ba9c32711af