1925291 - Show a warning message in the extensions panel when a soft-blocked extension has been re-enabled

Status: VERIFIED FIXED

(WebExtensions :: Frontend, enhancement, P2)

Description

[William Durand [:willdurand]]

Attachment: spec

We'll want to have a message-bar warning under a soft-blocked extension that has been re-enabled in the extensions panel. See the Figma spec.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1925291 - Propagate blocklistState to the Extension class instances. r?willdurand!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1925291 - Add Extensions Button panel a new per-item messagebar. r?willdurand!

Depends on D229902

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1925291 - Tweak themed icons css rules. r?willdurand!

This patches applied tweaks to the CSS rules that are meant to choose the right browserAction
theme icon based on the theme colors.

In addition to that this patch includes a tweak (unrelated to the changes applied to the CSS rules)
to the test that would be hitting a failure if the CSS rules are not applied to the browserAction
toolbar-button as the test cases from this test file expects.

This is currently split out from the parent patch including the rest of the frontend changes
because these rules seems worth an additional close look.

Depends on D229904

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac2a87182d6a
Propagate blocklistState to the Extension class instances. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/46bd418a9e54
Add Extensions Button panel a new per-item messagebar. r=willdurand,fluent-reviewers,desktop-theme-reviewers,dao,flod
https://hg.mozilla.org/integration/autoland/rev/540773496872
Tweak themed icons css rules. r=willdurand,desktop-theme-reviewers,dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a6ce904c3f5
Fix lint failure r=fix CLOSED TREE

Comment 6

[agoloman]

Backed out for causing dt failures @browser_aboutdebugging_addons_debug_console.js.

• Backout link
• Push with failures
• Failure Log
  ————————————————————————————————————
• Push with failures lint failures.
• Failure Log

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b58c882dc4b
Backed out changeset 2a6ce904c3f5 for causing dt failures @browser_aboutdebugging_addons_debug_console.js.

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

The failure hit by browser_aboutdebugging_addons_debug_console.js was due to one more test helper triggering the browser action click on the wrong element, this was unfortunately was missed by the push to try.

Also fixed the eslint prettier formatting error, which I guess may have been due to an update to prettier happening between my previous push to try from last week and when I pushed it to autoland today.

I'll push to autoland the updated stack asap.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f4b4a057816
Propagate blocklistState to the Extension class instances. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/993b49184d2f
Add Extensions Button panel a new per-item messagebar. r=willdurand,fluent-reviewers,desktop-theme-reviewers,dao,flod,devtools-reviewers,ochameau
https://hg.mozilla.org/integration/autoland/rev/08427977fd30
Tweak themed icons css rules. r=willdurand,desktop-theme-reviewers,dao

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/9f4b4a057816
https://hg.mozilla.org/mozilla-central/rev/993b49184d2f
https://hg.mozilla.org/mozilla-central/rev/08427977fd30

Comment 11

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (135.0a1/20241205213207) under Windows 10, Ubuntu 22.04 LTS and macOS 11.3.1.

Once a soft-blocked extension is re-enabled a warning strip will appear under the add-on entry in the extensions panel stating “{addon_name} violates Mozilla’s policies. Using it may be risky.”

See attached screenshot for more details.

Comment 12

[Alex Cornestean]

Attachment: 2024-12-06_15h40_56.png