Disable experimental.json_parse_with_source by default in 132 beta and nightly
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
People
(Reporter: bthrall, Assigned: bthrall)
References
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
The JSON.parse with source feature is causing unacceptable slowdown, so it should be disabled by default in Nightly and the 132 Beta
Assignee | ||
Comment 1•2 months ago
|
||
Updated•2 months ago
|
Comment 3•2 months ago
|
||
Backed out for causing spider-monkey failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/2f532998f27be91acaca62447975bf7b73c00c9f
Assignee | ||
Updated•2 months ago
|
Comment 5•2 months ago
|
||
bugherder |
Assignee | ||
Comment 7•2 months ago
|
||
Comment on attachment 9431642 [details]
Bug 1925334 - Default to disabling JSON.parse with source r=dminor!
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: Websites using JSON.parse with a reviver function could see significant performance regressions if the 'JSON.parse with source' feature is enabled by default.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Disabling the feature reverts to existing behavior
- String changes made/needed:
- Is Android affected?: Unknown
Comment 8•2 months ago
|
||
Comment on attachment 9431642 [details]
Bug 1925334 - Default to disabling JSON.parse with source r=dminor!
Approved for 132.0rc1.
Updated•2 months ago
|
Comment 10•2 months ago
|
||
This needs the release notes to be modified since this feature was scheduled for Firefox 132. It's already mentioned at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/132#javascript and it could be moved to the experimental section there and mention that it is off by default.
Description
•