1925417 - [Fission] Adjust expectations for UNEXPECTED-PASS

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[[:owlish] 🦉 PST]

We have fixed a lot of timeouts in 1522790, as well as fixed a lot of various Fission issues and shipped SHIP. That uncovered some unexpected passes, and we need to adjust the expectations for those. Tests affected:

W, W-cf

• TEST-UNEXPECTED-PASS | /html/dom/idlharness.https.html
• TEST-UNEXPECTED-OK | /preload/preconnect-onerror-event.html
• TEST-UNEXPECTED-PASS | /html/browsers/history/the-history-interface/traverse-during-unload.html
• TEST-UNEXPECTED-PASS | /intersection-observer/cross-origin-iframe.sub.html
• TEST-UNEXPECTED-PASS | /css/css-conditional/container-queries/font-relative-units-dynamic.html
• TEST-UNEXPECTED-PASS | /resource-timing/no-entries-for-cross-origin-css-fetched.sub.html

W-b

• TEST-UNEXPECTED-OK | /editing/other/join-different-white-space-style-left-line-and-right-paragraph.html
• TEST-UNEXPECTED-OK | /editing/other/join-different-white-space-style-left-paragraph-and-right-line.html
• TEST-UNEXPECTED-OK | /editing/other/join-different-white-space-style-paragraphs.html
• TEST-UNEXPECTED-OK | /encoding/legacy-mb-korean/euc-kr/euckr-decode.html
• TEST-UNEXPECTED-OK | /encoding/legacy-mb-korean/euc-kr/euckr-encode-form-ks_c_5601-1989.html
• TEST-UNEXPECTED-PASS | /webmessaging/postMessage_cross_domain_image_transfer_2d.sub.htm
• TEST-UNEXPECTED-OK | /webmessaging/postMessage_cross_domain_image_transfer_2d.sub.htm
• TEST-UNEXPECTED-OK | /largest-contentful-paint/image-upscaling.html
• TEST-UNEXPECTED-OK | /html/canvas/offscreen/... x32

Comment 1

[Olivia Hall [:olivia]]

I have notes on some of these for bug 1919775, so just linking them as related. I think some of these just went through in bug 1925435 as well.

Comment 2

[Olivia Hall [:olivia]]

Some of this test metadata has been updated elsewhere over a couple of tickets, but I'm not sure if that is true for all of the conditions. Sent a preset try up with android-geckoview on Dec 5. MC branch to figure out which ones remain. I'll update this ticket with what is missing after that completes.

Comment 3

[Olivia Hall [:olivia]]

Looks like the list has reduced considerably due to bug 1919837 and bug 1925435:

W and W-cf:

• TEST-UNEXPECTED-PASS | /css/css-conditional/container-queries/font-relative-units-dynamic.html - wpt7
• TEST-UNEXPECTED-OK | /permissions/non-fully-active.https.html | expected ERROR - wpt13
• TEST-UNEXPECTED-PASS | /resource-timing/no-entries-for-cross-origin-css-fetched.sub.html | Make sure that resources fetched by cross origin CSS are not in the timeline. - expected FAIL - wpt13
  • Need to look at bug 1903928 to confirm what is going on

W-b:

• TEST-UNEXPECTED-OK | /largest-contentful-paint/image-upscaling.html | expected TIMEOUT - wpt3

I'll add a patch soon to fix these. I'll also double check the metadata on the ones originally listed on this bug to make sure the metadata wasn't set to accept the unexpected passes.

Comment 4

[Olivia Hall [:olivia]]

Previous tests listed in Comment 0 that weren't reproducing seem to all have updated metadata as expected.

Still looking for ini/metadata on /preload/preconnect-onerror-event.html, join-different-white-space-style-left-line-and-right-paragraph.html and/encoding/legacy-mb-korean/euc-kr/euckr-decode.html. Ohh, it is because it was removed in bug 1925435. All prior reports seem as expected now.

Comment 5

[Olivia Hall [:olivia]]

With more testing, while preparing a patch, TEST-UNEXPECTED-PASS | /css/css-pseudo/target-text-dynamic-002.html also shows up sometimes, but I think this is unrelated to the timeout fixes and a true intermittent in bug 1890395. I won't change metadata here.

Comment 6

[Olivia Hall [:olivia]]

Attachment: Bug 1925417 - [Fission] Adjust expectations for UNEXPECTED-PASS

Patch updates the metadata based on some timeout fixes the allowed these
tests to process.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/320b23c7e0aa
[Fission] Adjust expectations for UNEXPECTED-PASS r=sefeng,kaya

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/320b23c7e0aa