1925522 - [Menu Redesign] Extensions subtext is not displayed in the Main menu

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P1)

Description

[Vasilica Tamas QA [:vtamas]]

Attachment: NoExtensionsText.jpg

Preconditions

• Enable Menu Redesign feature from Secret Settings.

Steps to reproduce

1. Make sure that there are no extensions installed.
2. Navigate to a webpage.
3. Open the Main menu and check the Extensions menu item text.
4. Install a few extensions.
5. Open the Main menu and check the Extensions menu item text.
6. Disable all the installed extensions.
7. Open the Main menu and check the Extensions menu item text.

Expected behavior

Step 3: The displayed text: "No extensions enabled" - figma
Step 5: The displayed text: The extensions are listed within the limits of the available character space. - figma
Step 7: The displayed text: "No extensions enabled" - figma

Actual behavior

No text is displayed for any of the three cases.

Device information

• Firefox version: Firefox Nightly 133 (2024-10-17)
• Android device model: Samsung Galaxy S24 Ultra (Android 14), Lenovo Tab P11 Pro (Android 13)

Comment 1

[Iorga Gabriel]

Attachment: Bug 1925522 - [Menu Redesign] Extensions subtext should be displayed in the Main menu.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bda42a9705b3
[Menu Redesign] Extensions subtext should be displayed in the Main menu. r=android-reviewers,avirvara

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bda42a9705b3

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[amarc]

Backed out for causing Fenix test-apk-debug permafailure

• Backout link
• Push with failures
• Failure Log
• Failure snippet:

[task 2024-10-29T18:09:12.800Z] 
[task 2024-10-29T18:09:12.800Z]   TEST: WHEN find in page action is dispatched THEN find in page app action is dispatched
[task 2024-10-29T18:09:12.800Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-10-29T18:09:12.800Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #462
[task 2024-10-29T18:09:12.800Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #549
[task 2024-10-29T18:09:12.800Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #558
[task 2024-10-29T18:09:12.800Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #567
[task 2024-10-29T18:09:12.800Z]   SUCCESS
[task 2024-10-29T18:09:12.800Z] 
[task 2024-10-29T18:09:12.800Z]   TEST: GIVEN at least one addon is installed WHEN init action is dispatched THEN initial extension state is updated
[task 2024-10-29T18:09:12.800Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-10-29T18:09:12.900Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #462
[task 2024-10-29T18:09:12.900Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #549
[task 2024-10-29T18:09:12.900Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #558
[task 2024-10-29T18:09:12.900Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #567
[task 2024-10-29T18:09:12.900Z]   SUCCESS
[task 2024-10-29T18:09:12.900Z] 
[task 2024-10-29T18:09:12.900Z]   TEST: GIVEN selected tab is pinned WHEN remove from shortcuts action is dispatched THEN pinned state is updated
[task 2024-10-29T18:09:12.900Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-10-29T18:09:12.900Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #462
[task 2024-10-29T18:09:12.900Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #549
[task 2024-10-29T18:09:12.900Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #558
[task 2024-10-29T18:09:12.900Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #567
[task 2024-10-29T18:09:13.000Z]   SUCCESS
[task 2024-10-29T18:09:13.000Z] 
[task 2024-10-29T18:09:13.000Z]   TEST: GIVEN selected tab is bookmarked WHEN add bookmark action is dispatched THEN add bookmark use case is never called
[task 2024-10-29T18:09:13.000Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-10-29T18:09:13.000Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #462
[task 2024-10-29T18:09:13.000Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #549
[task 2024-10-29T18:09:13.000Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #558
[task 2024-10-29T18:09:13.000Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #567
[task 2024-10-29T18:09:13.000Z]   SUCCESS
[task 2024-10-29T18:09:13.000Z] 
[task 2024-10-29T18:09:13.000Z]   TEST: WHEN customize reader view action is dispatched THEN reader view action is dispatched
[task 2024-10-29T18:09:13.000Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-10-29T18:09:13.000Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #462
[task 2024-10-29T18:09:13.000Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #549
[task 2024-10-29T18:09:13.000Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #558
[task 2024-10-29T18:09:13.000Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #567
[task 2024-10-29T18:09:13.100Z]   SUCCESS
[task 2024-10-29T18:09:13.100Z] 
[task 2024-10-29T18:09:13.100Z]   TEST: WHEN CFR is dismissed THEN dismiss CFR action is dispatched
[task 2024-10-29T18:09:13.100Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-10-29T18:09:13.100Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #462
[task 2024-10-29T18:09:13.100Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #549
[task 2024-10-29T18:09:13.100Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #558
[task 2024-10-29T18:09:13.100Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #567
[task 2024-10-29T18:09:13.100Z]   SUCCESS
[task 2024-10-29T18:09:13.100Z] 
[task 2024-10-29T18:09:13.100Z]   TEST: GIVEN selected tab is readerable and reader view is on WHEN toggle reader view action is dispatched THEN reader view state is updated
[task 2024-10-29T18:09:13.200Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-10-29T18:09:13.200Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #462
[task 2024-10-29T18:09:13.200Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #549
[task 2024-10-29T18:09:13.200Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #558
[task 2024-10-29T18:09:13.200Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #567
[task 2024-10-29T18:09:13.200Z]   SUCCESS
[task 2024-10-29T18:09:13.200Z] 
[task 2024-10-29T18:09:13.200Z]   TEST: WHEN delete browsing data and quit action is dispatched THEN onDeleteAndQuit is invoked
[task 2024-10-29T18:09:13.200Z]     W/PackageParser: Unknown element under <manifest>: queries at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #70
[task 2024-10-29T18:09:13.200Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #462
[task 2024-10-29T18:09:13.200Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #549
[task 2024-10-29T18:09:13.200Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #558
[task 2024-10-29T18:09:13.200Z]     W/PackageParser: Unknown element under <service>: property at /builds/worker/checkouts/gecko/mobile/android/fenix/app/build/intermediates/apk_for_local_test/fenixDebugUnitTest/packageFenixDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #567

[taskcluster:error] Task timeout after 7200 seconds. Force killing container.
[taskcluster 2024-10-29 19:56:28.423Z] === Task Finished ===
[taskcluster 2024-10-29 19:56:28.423Z] Unsuccessful task run with exit code: -1 completed in 7202.359 seconds

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e86d02ff8f7e
[Menu Redesign] Extensions subtext should be displayed in the Main menu. r=android-reviewers,avirvara

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e86d02ff8f7e

Comment 8

[Vasilica Tamas QA [:vtamas]]

Attachment: ExtensionsName.JPEG

This issue is verified as fixed on Firefox Nightly 134 (2024-11-14) under Samsung S24 Ultra (Android 14) and Lenovo tab P11 Pro (Android 13). Confirming that:

• "No extensions enabled" subtext is displayed when there are no extensions installed
• "No extensions enabled" subtext is displayed when all extensions are disabled
• the extensions's name is successfully displayed as a subtext when it is enabled