Open Bug 1925523 Opened 24 days ago Updated 3 days ago

[Toolbar Redesign] Modify Sandbox Custom Tab navbar to remove Open in Firefox and Share

Categories

(Fenix :: Toolbar, task, P2)

All
Android
task

Tracking

(Not tracked)

People

(Reporter: tchoh, Assigned: skhan)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fxdroid][group3][toolbar-redesign-beta-blocker] )

Attachments

(6 files)

Summary: Discussed with Tom the need to update the Custom Tab navigation bar and menu options without impacting the original functionality of Sandbox Custom Tabs.

Purpose: Ensure that the original intent of the Sandbox Custom Tabs, launched from this link, remains intact. Specifically, the user should not be able to bypass the onboarding flow by directly launching into the app.

Requested Changes:

  1. The navigation bar should retain the same options as it had before the Toolbar Redesign project.
  2. The menu should remain the same, except for the removal of the share option.
Attached image current-navbar.png

This is the new design that was implemented with the Toolbar Redesign. Notice the navbar on the bottom.

The original sandbox custom tab. It doesn't have a navbar but it still has an option to allow users to select the 3 button menu (old design) without the share.

Attached image navbar_share.png

ignore the leak canary.
This highlights the 3 dot menu, but this has the share. we should remove the share option from the menu.

Whiteboard: [fxdroid][group3]

Backlog refinement notes:

We can't point this until we have a bit more context about the needs of the sandbox custom tabs.

  • We should keep the new menu and nav bar infrastructure as-is but modify it as needed to fulfill the needs of the sandbox custom tabs (rather than maintaining old infrastructure for the sandbox custom tabs)
  • What we need: Channing should work with whatever PM Tom was representing to make sure the needs of the Toolbar work are cooperating with whatever their needs are. Ultimately, we really just need to know (a) what options should exist in the menu for sandbox custom tabs; (b) what options should exist in the nav bar for sandbox custom tabs (it sounds like the answer is "whatever existed in the toolbar + menu before the toolbar redesign", but it would help to just have those outlined explicitly)

Tim is planning on following up with Channing about this.

Flags: needinfo?(tchoh)

I think 2 things are potentially overlapping a little here. The sandboxed tab is to ensure users can't bypass the onboarding flow by opening the privacy policy link directly in the app.

  1. Bug: I flagged this originally as a bug, as it breaks the onboarding flow for users who have the new toolbar enabled by allowing the onboarding flow to be bypassed by clicking the privacy policy and using the 'open in app' button. It may also have other side effects. The fix for this can be to prevent users from being able to use the 'open in app' button during onboarding (the sandboxed tab).

  2. Task: I think:

what options should exist in the menu for sandbox custom tabs

&

what options should exist in the nav bar for sandbox custom tabs

are potentially a different task.

Attached video existing onboarding.mp4

The "Firefox privacy notice" is pressed to access the sandboxed custom tab.

The "Firefox privacy noticed" is pressed.

Toolbar
Sandbox Custom Tab - Link

  • ‘Open in Firefox app’ feature - The 3rd icon from the left in the bottom navigation bar that represents ‘open in Firefox app’ feature should be disabled.
  • ‘Share’ feature - Similar to regular custom tab, we will not display/provide access to the share feature in the top toolbar (address bar) and will be hidden. The ‘Share’ feature will be available in the menu.

Menu
Sandbox Custom Tab - Link

  • ‘Open in Firefox app’ feature - The menu item should be disabled.
  • ‘Share’ feature - The ‘Share’ feature will be available to use in the menu.

Should there be a separate ticket for the Menu work in the above message?

Flags: needinfo?(cpeterson)

Refinement notes:

  • Roger: Toolbar should be straightforward; Menu is a bit more suspicious
  • Roger: testing is an unknown, particularly to understand the set of circumstances that could lead to this custom tab experience
    --> Zac: if we want to highlight that concern, we could create a separate ticket for validating the various entry points into the app
  • Zac: Do we have a way to differentiate custom tabs from the regular menu?
    --> Sanchaai: we have a fully separate custom tab menu
  • Tim: worth separating Toolbar and Menu

Let's separate this into:

  • Update Toolbar
  • Update Menu
  • (dependent on both of them) Test & validate the entry points

Zac, could you (or someone from the squad) update this ticket & create the additional two tickets as described above?

Flags: needinfo?(zmckenney)
Flags: needinfo?(tchoh)
Flags: needinfo?(cpeterson)
Flags: needinfo?(zmckenney)
Whiteboard: [fxdroid][group3] → [fxdroid][group3][toolbar-redesign-beta-blocker]
Summary: [Toolbar Redesign] Modify Sandbox Custom Tab navbar and menu actions → [Toolbar Redesign] Modify Sandbox Custom Tab navbar to remove Open in Firefox and Share
See Also: → 1927879
Blocks: 1927880
Assignee: nobody → skhan
Severity: -- → N/A
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: