1925535 - [Menu Redesign] "Share" menu item from Custom tab doesn't include the ellipsis

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect, P3)

Description

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: ShareMenuItem.JPEG

Preconditions

• Fenix is set as default browser.
• Enable Menu Redesign feature from Secret Settings.

Steps to reproduce

1. Open an external app (i.e. Gmail, Instagram, Slack) and tap on a link.
2. Tap on 3 dots menu.
3. Check the "Share..." menu item.

Expected behavior

"Share..." menu item from Custom tab have ellipsis. (like "Share..." item from the Tools menu)

Actual behavior

"Share..." menu item from Custom tab does not have ellipsis.

Device information

• Firefox version: Firefox Nightly 133 (2024-10-17)
• Android device model: Samsung Galaxy S24 Ultra (Android 14) and Xiaomi 12T (Android 12)

Any additional information?

@aarjav confirmed this issue on slack.

Comment 1

[Sanchaai [:sanchaai]]

Attachment: Bug 1925535 - "Share" menu item from Custom tab doesn't include the ellipsis. r=gl

"Share..." menu item from Custom tab menu should have ellipsis, like "Share..." item from the Tools submenu.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b890272a396
"Share" menu item from Custom tab doesn't include the ellipsis. r=android-reviewers,skhan

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4b890272a396

Comment 4

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: ShareEllipsis.JPEG

This issue is verified as fixed on Firefox Nightly 133 (2024-10-28) using a Samsung Galaxy S24 Ultra and a Xiaomi 12T (Android 12). The ellipsis were successfully added to "Share" menu item.