Closed Bug 1925651 Opened 2 years ago Closed 2 years ago

Multiple webchannel messages might be in-flight at the same time

Categories

(Firefox :: Firefox Accounts, defect)

defect

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: markh, Assigned: markh)

References

Details

Attachments

(1 external file)

In the webchannel code, many of the things we do are async. This means there's a chance that if multiple messages come in quickly, we will start handling later ones before the async work we are doing in earlier ones has completed.

We don't hit this in practice currently, but do with oauth enabled - we might get a login message followed very quickly after by an oauth_login message - the latter relies on the former completing, but there are no guarantees it does. This is reproducible if you log in an already verified user.

Assignee: nobody → markh
Status: NEW → ASSIGNED
Pushed by mhammond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d037f59a2e2 ensure multiple fxa webchannel messages can't be in flight. r=lina
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: