1925657 - use ffmpeg for av1 on all platforms

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

Currently AV1 decoding through ffmpeg is only used on Linux. On Windows, we use DAV1DDecoder for sw av1. However, we would like to use ffmpeg on AV1 as well.

However, simply enabling FFMPEG_AV1_DECODE on Windows doesn't work, it raised an error Couldn't open avcodec. We need to fix it in order to use ffvpx for av1 on Windows.

2024-10-18 19:16:40.884000 UTC - [RDD 39884: MediaPDecoder #1]: D/FFmpegVideo FFVPX: Initialising FFmpeg decoder
2024-10-18 19:16:40.884000 UTC - [RDD 39884: MediaPDecoder #1]: D/FFmpegVideo FFVPX:   codec av1 : Alliance for Open Media AV1
2024-10-18 19:16:40.884000 UTC - [RDD 39884: MediaPDecoder #1]: D/FFmpegVideo FFVPX: Set get_buffer2 for customized buffer allocation
2024-10-18 19:16:40.884000 UTC - [RDD 39884: MediaPDecoder #1]: D/FFmpegVideo FFVPX:   Couldn't open avcodec for av1
[Child 12012, MediaSupervisor #1] WARNING: NS_ERROR_DOM_MEDIA_FATAL_ERR (0x806e0005) - MediaResult __cdecl mozilla::FFmpegDataDecoder<46465650>::InitDecoder(AVDictionary **): Couldn't open avcodec: file C:/mozilla-source/mozilla-unified/dom/media/MediaFormatReader.cpp:1843

Comment 1

[Alastor Wu [:alwu]]

Actually, we should use ffvpx for AV1 on all platforms, not just Windows.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1925657 - use ffvpx for SW AV1 on all platforms.

FFvpx internally uses dav1decoder for AV1 SW.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a56901d19160
use ffvpx for SW AV1 on all platforms. r=padenot

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing Android build bustages.

• Backout link
• Push with failures
• Failure Log
• Failure line: ld.lld: error: undefined symbol: ff_libdav1d_decoder

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab86b4883528
use ffvpx for SW AV1 on all platforms. r=padenot

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ab86b4883528