Closed Bug 1925668 Opened 28 days ago Closed 24 days ago

[wpt-sync] Sync PR 48704 - Fix strings within GitHub Actions workflow expressions

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox133 fixed)

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48704 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48704
Details from upstream follow.

Sam Sneddon <gsnedders@apple.com> wrote:

Fix strings within GitHub Actions workflow expressions

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#literals:

You don't need to enclose strings in ${{ and }}. However, if you do,
you must use single quotes (') around the string. To use a literal
single quote, escape the literal single quote using an additional
single quote (''). Wrapping with double quotes (") will throw an
error.

And in a shocking turn of events, using double quotes did in fact throw an error.

PR 48704 applied with additional changes from upstream: b4847226b3e278f0daea1f22d137fb2da1bb50b6, 7e91324675c24957fa5bdf82b16f0c337754cb17
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a7fa909fe25 [wpt PR 48704] - Fix strings within GitHub Actions workflow expressions, a=testonly
Status: NEW → RESOLVED
Closed: 24 days ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.