Closed
Bug 1925735
Opened 4 months ago
Closed 3 months ago
Update weather suggestions tests
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
133 Branch
Tracking | Status | |
---|---|---|
firefox133 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [sng-cityweather] )
Attachments
(1 file)
I changed the remote settings schema for weather suggestions as part of the work for city-based weather. I also changed the keyword-matching behavior a little. We need to update the weather-related tests to account for these changes.
Updated•4 months ago
|
Assignee | ||
Comment 1•4 months ago
|
||
This replaces MerinoTestUtils.WEATHER_RS_DATA
with
QuickSuggestTestUtils.weatherRecord()
. Weather records now have an attachment
instead of storing their keywords inline. I also removed
MerinoTestUtils.WEATHER_KEYWORD
because I think it's fine to use "weather"
directly everywhere, and that's simpler.
Some tests also need to be updated for the slight changes in keyword matching,
and some tasks don't make sense anymore.
Depends on D226214
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28afdd8eb8a3
Update weather suggestions tests. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•