1925808 - Make GMPVideoi420FrameImpl use a single shmem

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1925808 - Part 1. Make GMPVideoi420FrameImpl use a single ipc::Shmem.

GMP would split its frames across 3 different shmems, one for each plane
in the decoded video. This made refactoring more complicated, as well as
unnecessarily increased the number of sync IPDL calls from the GMP
process back to the parent.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1925808 - Part 2. Remove shmem usage from GMPVideoPlaneImpl.

Now that we don't use GMPVideoPlaneImpl inside of GMPVideoi420FrameImpl,
there are no uses of GMPVideoPlaneImpl inside of our GMP implementation.
It is exposed as part of the GMP API, so we must continue to supply it,
but there is no need for it to be IPDL aware/performant.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/235e87dd6bd0
Part 1. Make GMPVideoi420FrameImpl use a single ipc::Shmem. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/fb887a7aebf3
Part 2. Remove shmem usage from GMPVideoPlaneImpl. r=media-playback-reviewers,padenot

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/235e87dd6bd0
https://hg.mozilla.org/mozilla-central/rev/fb887a7aebf3