1925825 - nsMsgDBService::OpenMailDBFromFile() Creates wrong type of database for IMAP

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[Ben Campbell]

nsMsgDBService::OpenMailDBFromFile() is the main (only?) function for creating a msgDB without an attachment to a folder.
However, it always creates a nsMailDatabase, which is no use for IMAP (nsImapMailDatabase) or NNTP (nsNewsDatabase).

There are a couple of places in IMAP which use it currently (I've come across it in Bug 1921694), so I'm sure there are some lovely subtle issues screwing things up somewhere :-)

But in particular, there's currently no way to create a stand-alone database for IMAP, which I really want for folder compaction over in Bug 1925117.

Comment 1

[Ben Campbell]

Attachment: Bug 1925825 - Part 1 of 2 - Tweak nsMsgDBService::OpenMailDBFromFile() to use db filename rather than folder path. r=#thunderbird-back-end-reviewers

The whole point of OpenMailDBFromFile() is that you can use it to access a db
in an arbitrary file, so it's a bit silly having to pass in a folder path.
It still only creates nsMailDatabase objects (used for local folders, not for
imap/news/etc), but that's coming in part 2.

Comment 2

[Ben Campbell]

Attachment: Bug 1925825 - Part 2 of 2 - Make nsMsgDBService::OpenDBFromFile() open the correct type of database. r=#thunderbird-back-end-reviewers

This also renames .openMailDBFromFile() to .openDBFromFile(), as it's no longer
unconditionally creating an nsMailDatabase.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cc6efed0e653
Part 1 of 2 - Tweak nsMsgDBService::OpenMailDBFromFile() to use db filename rather than folder path. r=thunderbird-back-end-reviewers,darktrojan
https://hg.mozilla.org/comm-central/rev/d620463f133f
Part 2 of 2 - Make nsMsgDBService::OpenDBFromFile() open the correct type of database. r=thunderbird-back-end-reviewers,darktrojan