Closed
Bug 1925849
Opened 1 year ago
Closed 1 year ago
Remove use of NSGetModule in DOMi
Categories
(SeaMonkey :: General, task)
Tracking
(seamonkey2.53+ fixed)
RESOLVED
FIXED
seamonkey2.53
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
1.98 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
As DOM Inspector is built-in, no longer need to have the backwards compatibility of NSGetModule, so let's remove it.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9432094 -
Flags: review?(frgrahl)
Attachment #9432094 -
Flags: approval-comm-release?
|
||
Updated•1 year ago
|
status-seamonkey2.53:
--- → affected
tracking-seamonkey2.53:
--- → ?
Whiteboard: SM2.53.20
Version: Trunk → SeaMonkey 2.53 Branch
|
|
||
Comment 2•1 year ago
|
||
Comment on attachment 9432094 [details] [diff] [review]
1925849-domi-cmdline-25320.patch
lgtm r/a+ for 2.53 branch. Gone in central.
Nit 2 blank lines at the end of inspector-cmdline.js before the last statement. One could go.
Attachment #9432094 -
Flags: review?(frgrahl)
Attachment #9432094 -
Flags: review+
Attachment #9432094 -
Flags: approval-comm-release?
Attachment #9432094 -
Flags: approval-comm-release+
|
|
||
Comment 3•1 year ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/bdc33d4a5b46a34acc60f7a42d31ae139b173d13
Remove use of NSGetModule in DOMi. r=frg a=frg
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
|
||
Updated•1 year ago
|
Version: SeaMonkey 2.53 Branch → SeaMonkey 2.53
You need to log in
before you can comment on or make changes to this bug.
Description
•