192600 - style_urls not included in header for buglist.cgi generated pages

Status: RESOLVED INVALID

(Bugzilla :: User Interface, defect)

Description

[David Earle]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20021120 Netscape/7.01
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20021120 Netscape/7.01

style.css files added to style_urls of /global/header.html.tmpl file change the
stylesheet, as they're supposed to, for every page except those generated by
buglist.cgi.  For some reason, if instead of using style_urls I add the <link
rel...> tag manually (without any IF statements), all pages can load the
stylesheet including those created by buglist.cgi.  

Reproducible: Always

Steps to Reproduce:
1.Put a stylesheet changing how links like in the main bugzilla directory
2.Put style_urls = "stylesheetname.css"  in the global/header.html.tmpl file.
3.cvs update

Actual Results:  
Stylesheet will change appearances of all pages except those generated by
buglist.cgi queries.

Expected Results:  
Add the style changes to the query results

Comment 1

[David Earle]

I apologize for not proofreading that before sending.
"links like" should be "links look"
Sorry

Comment 2

[Gervase Markham [:gerv]]

> style.css files added to style_urls of /global/header.html.tmpl file change the
> stylesheet, as they're supposed to, for every page except those generated by
> buglist.cgi.

Er... I think you are labouring under a misapprehension. style_urls is something
we use internally, and shouldn't be messed with. If you want to add a stylesheet
to all Bugzilla pages, put a <link rel="stylesheet"...> pointing at your
stylesheet into header.html.tmpl. This will then be used on all pages.

Gerv

Comment 3

[Dave Miller [:justdave]]

The User Interface component now belongs to Gerv.  Reassigning all UNCONFIRMED
and NEW (but not ASSIGNED) bugs currently owned by Myk (the previous component
owner) to Gerv.

Comment 4

[Dave Miller [:justdave]]

Reassigning back to Myk.  That stuff about Gerv taking over the User Interface
component turned out to be short-lived.  Please pardon our confusion, and I'm
very sorry about the spam.

Comment 5

[Max Kanat-Alexander]

This bug has not been touched by its owner in over six months, even though it is
targeted to 2.20, for which the freeze is 10 days away. Unsetting the target
milestone, on the assumption that nobody is actually working on it or has any
plans to soon.

If you are the owner, and you plan to work on the bug, please give it a real
target milestone. If you are the owner, and you do *not* plan to work on it,
please reassign it to [e-mail] or a .bugs component owner. If you are
*anybody*, and you get this comment, and *you* plan to work on the bug, please
reassign it to yourself if you have the ability.

Comment 6

[apla]

Attachment: style_urls must be empy empty list, before push to it

Comment 7

[apla]

Attachment: push style to style_urls list

Comment 8

[Frédéric Buclin]

Invalid per comment 2 with which I fully agree. Since 2.19, you can also
customised all pages by editing skins/custom/global.css.

Comment 9

[Colin Joy]

It has been a while since this bug was discussed, but it might not be entirely invalid if the below recommendation still applies to 5.0:

> You should not insert <script> tags and <link> CSS tags into HTML anymore, 
> in Extensions or in your customizations. Instead, you should push new values 
> into the style_urls or javascript_urls parameters.
(from https://www.bugzilla.org/releases/4.4.1/release-notes.html | not mentioned in current docs)

I ran into this issue when adding JavaScript via hook/global/header-start
While the hook is run on every page as expected, pushing to javascript_urls had no effect on a number of pages (including the home/index and the first steps of enter_bug).

The problem is easily avoided by using a DEFAULT directive (assign if undefined) before pushing. E.g:

> [% DEFAULT
>   javascript_urls = []
>   style_urls = []
> %]
> 
> [% javascript_urls.push('extensions/MyExtension/js/script.js') %]
> [% style_urls.push('extensions/MyExtension/css/style.css') %]

Comment 10

[Gervase Markham [:gerv]]

LpSolit: should we add such a DEFAULT directive to header.html.tmpl or somewhere, to make sure these two arrays are always defined and so hooks and extensions can always push to them safely?

Gerv

Comment 11

[Frédéric Buclin]

global/header.html.tmpl already has a DEFAULT directive. style_urls is in the list, but javascript_urls is missing. Please file a separate bug for javascript_urls.

Comment 12

[Colin Joy]

filed Bug 1189813