Closed Bug 1926146 Opened 10 months ago Closed 10 months ago

Unnecessary JSOp::Try in `for (using x of y)`

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: arai, Assigned: debadree333)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1926146 - Remove stray JSOp::Try in `for (using x of y)` by passing block kind in disposable scope prep. r?arai!
48 bytes, text/x-phabricator-request
Details | Review

As discovered in https://phabricator.services.mozilla.com/D226251#7775576 , for (using x of y) emits unnecessary JSOp::Try, because of initializing TryEmitter in UsingEmitter::prepareForDisposableScopeBody, while not calling UsingEmitter::emitEnd.

So, we need to either:

  • Do not call UsingEmitter::prepareForDisposableScopeBody in for-of case.
  • Do not initialize TryEmitter in UsingEmitter::prepareForDisposableScopeBody for for-of case.
Assignee: nobody → debadree333
Status: NEW → ASSIGNED
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/e884b3a3c762 Remove stray JSOp::Try in `for (using x of y)` by passing block kind in disposable scope prep. r=arai

https://hg.mozilla.org/mozilla-central/rev/e884b3a3c762

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: