1926225 - Avoid malloc/free for function's name in GeckoProfilerRuntime::allocProfileString

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Jan de Mooij [:jandem]]

Minor but I noticed this in a profile recently. Instead of using StringToNewUTF8CharsZ we should use DeflateStringToUTF8Buffer to write directly to the target buffer to avoid the extra malloc/free and string copy.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1926225 - Avoid malloc/free for UTF8 function name in GeckoProfilerRuntime::allocProfileString. r?jonco!

Write to the result string directly to avoid the extra allocation and strlen/memcpy.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0db86fb83c4
Avoid malloc/free for UTF8 function name in GeckoProfilerRuntime::allocProfileString. r=jonco

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e0db86fb83c4