Closed Bug 1926293 Opened 1 year ago Closed 1 year ago

Moving tab to existing group in another window breaks both windows

Categories

(Firefox :: Tabbed Browser, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
134 Branch
Tracking Status
firefox134 --- fixed

People

(Reporter: dao, Assigned: dwalker)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [fidefe-tabgrps-panels])

Attachments

(1 file, 1 obsolete file)

When attempting to move a tab to an existing group in another window, the original window ends up with no selected tab and the target window ends up with two selected tabs. I also see these errors in the browser console:

JavaScript error: chrome://browser/content/tabbrowser/tab.js, line 111: TypeError: this.initialize is not a function
JavaScript error: chrome://global/content/elements/text.js, line 99: TypeError: this.delayConnectedCallback is not a function
JavaScript error: chrome://global/content/elements/text.js, line 99: TypeError: this.delayConnectedCallback is not a function
JavaScript error: chrome://global/content/elements/text.js, line 99: TypeError: this.delayConnectedCallback is not a function
JavaScript error: chrome://global/content/elements/text.js, line 99: TypeError: this.delayConnectedCallback is not a function
JavaScript error: chrome://global/content/elements/text.js, line 99: TypeError: this.delayConnectedCallback is not a function
JavaScript error: chrome://global/content/elements/text.js, line 99: TypeError: this.delayConnectedCallback is not a function
Assignee: nobody → dwalker
Attachment #9432853 - Attachment description: WIP: Bug 1926293 - handle moving tabs into groups across windows. r?dao,jswinarton,sthompson → Bug 1926293 - handle moving tabs into groups across windows. r?dao,jswinarton,sthompson
Attachment #9432853 - Attachment is obsolete: true
Attachment #9432989 - Attachment description: WIP: Bug 1926293 - handle moving tabs into groups across windows. r?dao,jswinarton,sthompson → Bug 1926293 - handle moving tabs into groups across windows. r?dao,jswinarton,sthompson
Pushed by dwalker@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/884e1ad9d540 handle moving tabs into groups across windows. r=sthompson,tabbrowser-reviewers
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
Flags: qe-verify+
Depends on: 1928146

I would like to verify this fix, but I need steps to reproduce. How exactly does group tabs work? Is it a feature that needs to be enabled? Is it an addon? Can you help me?

Flags: needinfo?(dao+bmo)

:dwalker, can you help me with the request above instead? Thanks.

Flags: needinfo?(dwalker)

QA could not reproduce this window breakage on the affected Nightly v133.0a1 (2024-10-27) on Windows 10, MacOS 11.7.10, MacOS 15.3 and Ubuntu 22. In the lack of clear steps to reproduce, we will assume that the reporter might have a less common environment it reproduces on. In conclusion, we will remove the qe+ tag as we can't verify the fix if we can't reproduce the issue.
Please NI me for further testing if clear steps to reproduce are provided. Thank you!

Flags: qe-verify+
Flags: needinfo?(dwalker)
Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: