Open Bug 1926294 Opened 1 year ago Updated 5 months ago

Add tests for network requests using keepAlive: true

Categories

(Remote Protocol :: WebDriver BiDi, task, P3)

task
Points:
2

Tracking

(Not tracked)

People

(Reporter: jdescottes, Unassigned)

References

Details

(Whiteboard: [webdriver:backlog])

Similar to devtools Bug 1926042, we currently skip fetch requests with keepAlive: true, because we can't find the browsing context id associated with them.

Because of this our network module will bail out of emitting the events at: https://searchfox.org/mozilla-central/rev/dfc3050503739883ce6d17e8365bc35410106aba/remote/webdriver-bidi/modules/root/network.sys.mjs#1691-1698

const browsingContext = lazy.TabManager.getBrowsingContextById(
  request.contextId
);
if (!browsingContext) {
  // Do not emit events if the context id does not match any existing
  // browsing context.
  return;
}

keepAlive was enabled in Firefox for all channels in Bug 1923044

Severity: -- → S3
Points: --- → 3
Depends on: 1926042
Priority: -- → P2
See Also: 1926042
Whiteboard: [webdriver:backlog]

just in case, there's a speculative fix to add the missing association: https://github.com/aslushnikov/juggler/commit/30b05ab1132a6023c4a281bf568496f05c4381c8

Duplicate of this bug: 1944472

The keepAlive requests should now create the expected events thanks to

  • Bug 1897424 - Add capability to send NotifyNetworkMonitorAlternateStack for requests via PFetch originating from the main thread.

We can keep this bug to add a test but I think it can decrease to P3.

Severity: S3 → --
Type: defect → task
Points: 3 → 2
Depends on: 1897424
No longer depends on: 1926042
Priority: P2 → P3
Summary: Missing events for network requests using keepAlive: true → Add tests for network requests using keepAlive: true
You need to log in before you can comment on or make changes to this bug.