1926304 - metaflow.de - Drop-down option to select flavour does not work

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Raul Bucata]

Environment:
Operating system: Android 14
Firefox version: Firefox Mobile 131.0

Steps to reproduce:

1. Navigate to: https://metaflow.de/products/stoffwechsel-shake-suess
2. Scroll the page until the "Geschmack" option is present
3. Tap on the drop-down located below the said option and select a flavour
4. Observe

Expected Behavior:
Selection is made

Actual Behavior:
Nothing happens

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in Firefox Nightly, and Firefox Release
• Does not reproduce in Chrome

Created from https://github.com/webcompat/web-bugs/issues/142952

Comment 1

[Raul Bucata]

Attachment: 20241022_161325.mp4

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Reduced test-case.

So the issue is that the dialog closes on click, and that has some very subtle animation that is achieved by first setting the content as inert, then animating away (faked in this test-case with the setTimeout()).

The inert attribute somehow prevents the checkbox change to go through.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

So removing these lines fixes it, which raises the issue of what's the behavior of chrome if you do disabled rather than inert...

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Test-case that allows you to also set disabled around.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1926304 - Inert shouldn't behave as -moz-user-input: none. r=smaug

https://html.spec.whatwg.org/#inert-subtrees doesn't have anything about
stuff behaving as disabled.

I think we should remove -moz-user-input too, but that is probably worth
doing separately.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c30676d268f
Inert shouldn't behave as -moz-user-input: none. r=smaug

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49542 for changes under testing/web-platform/tests

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97e3fc291cd3
Annotate one more pass.

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4c30676d268f
https://hg.mozilla.org/mozilla-central/rev/97e3fc291cd3

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9441700 [details]
Bug 1926304 - Inert shouldn't behave as -moz-user-input: none. r=smaug

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes compat issues.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One liner.
• String changes made/needed: none
• Is Android affected?: No

Comment 14

[Pascal Chevrel:pascalc]

Emilio, should https://hg.mozilla.org/mozilla-central/rev/97e3fc291cd3 also be uplifted? Thanks

Comment 15

[Emilio Cobos Álvarez [:emilio]]

Yeah, it's a test-only change tho (marks a test as passing).

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8e3b1b0f75bd
https://hg.mozilla.org/releases/mozilla-beta/rev/be63456201e3

Comment 17

[Raul Bucata]

Verified as fixed on the latest Firefox Beta 134.0b9 and Firefox Nightly 135.0a1

Tested with:

Browser / Version: Firefox Nightly 135.0a1 (2016061287-🦎135.0a1-20241211100250🦎)/ Firefox Beta 134.0b9 (2016061295-🦎134.0-20241211100452🦎)
Operating System: Google Pixel 3 (Android 12) -1080 x 2160 pixels, 18:9 ratio (~443 ppi density)
Operating System: Oppo Find X5 (Android 13) - 1080 x 2400 pixels, 20:9 ratio (~402 ppi density)

Notes:
Beta versions lower than Firefox Beta 134.0b9 are still reproducing the issue