1926359 - Tab groups hairline should extend across group when reordering/adding new tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Amy Lee [:amylee] UX]

Attachment: Tab group hairline.mov

Steps to reproduce:

1. Create a group via drag and drop (or context menu)
2. Drag a new tab into the created group

Expected:
Hairline extends to the space/gap where the new tab will be dropped

Actual:
Hairline disappears and only appears when user drops the tab in position

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1926359 - Add tab group line to dragged tabs when dragging into a group. r=dwalker,sthompson,jswinarton

Ideally the line should cover the whole group, but I don't know that we can do this given our use of display:contents. If someone has ideas we can file a followup on that. As it stands the line will extend under dragged tabs themselves, but left or right from those there can be gaps in the line.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28bf7ae3c042
Add tab group line to dragged tabs when dragging into a group. r=dwalker,tabbrowser-reviewers

Comment 3

[Dão Gottwald [:dao]]

Tagging Amy to review this in the next Nightly build after this bug gets resolved.

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/28bf7ae3c042

Comment 5

[Amy Lee [:amylee] UX]

Attachment: Hairline breaks in group

Comment 6

[Amy Lee [:amylee] UX]

Hi, the hairline still breaks when a tab is dragged into the group. It looks like the hairline is linked to the tab being dragged and it's not linked to the tab group itself (when the spacing expands between tabs it should have the hairline extend across the group with no gap. I added a screen recording for reference.