1926381 - Integrate MLSuggest with UrlbarProviderQuickSuggest

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Integrate MLSuggest with UrlbarProviderQuickSuggest

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1926381 - Integrate MLSuggest with UrlbarProviderQuickSuggest and implement Yelp ML suggestions.

This adds a new Suggest backend for ML-based suggestions called
SuggestBackendMl. Before, with the JS and Rust backends, only one backend was
enabled at a time, but both the ML and Rust backends can be enabled at the same
time since we will want to serve suggestions from both for the foreseeable
future. Features can support ML suggestions by implementing the new
BaseFeature.mlIntent getter and handling ML suggestions in makeResult().
Each feature we can decide whether it supports ML suggestions and whether they
should be preferred over Rust suggestions.

I've updated the Yelp feature to hook into this, since Yelp suggestions are
supported by the ML model that Chidam is working on. If ML is enabled, then the
feature will only serve ML suggestions. I'm not sure if that's what we want long
term, but for now that will make it clear to people which backend is being used
while we develop this feature.

The quickSuggestMlEnabled variable/pref determines whether the ML backend is
enabled. The yelpMlEnabled variable/pref determines whether Yelp ML
suggestions are enabled. We can create similar variable/prefs for each feature
that supports ML suggestions so that they can be toggled independently of each
other.

Other changes:

Move the is_sponsored logic out of the Rust backend and into the provider.
Otherwise it would need to be duplicated in the ML backend too.

Depends on D224523

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/883bbd496804
Integrate MLSuggest with UrlbarProviderQuickSuggest and implement Yelp ML suggestions. r=daisuke

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/883bbd496804