1926382 - Group label covers tab when dragging a tab

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: label covers tab.mov

Steps to reproduce:

1. Create 2 tab groups with 2+ tabs inside each
2. Drag a tab from one group to the other

Expected:
Labels don't overlap with tabs
Tab group hairline doesn't follow the tab once it's moved out of the group

Actual:

Tab group label overlaps with tab when moving a tab between groups
Tab group hairline follows tab when moved out of the group

See screen recording for reference

Comment 1

[Stephen Thompson [:sthompson]]

Attachment: WIP: Bug 1926382 - hacky way to shift tab group labels

Comment 2

[Stephen Thompson [:sthompson]]

Attachment: WIP: Bug 1926382 - refactor tab dragdrop to item dragdrop

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1926382 - Shift group labels along with the group's first tab. r=sthompson

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4424e72e5872
Shift group labels along with the group's first tab. r=sthompson,tabbrowser-reviewers

Comment 5

[Phabricator Automation]

Comment on attachment 9437620 [details]
WIP: Bug 1926382 - hacky way to shift tab group labels

Revision D228932 was moved to bug 1908439. Setting attachment 9437620 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9437621 [details]
WIP: Bug 1926382 - refactor tab dragdrop to item dragdrop

Revision D228933 was moved to bug 1908439. Setting attachment 9437621 [details] to obsolete.

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4424e72e5872

Comment 8

[Ada C.]

Hi, Amy

Could you provide what add-on did you use for tab groups?

Comment 9

[Dão Gottwald [:dao]]

(In reply to Ada C. from comment #8)

Hi, Amy

Could you provide what add-on did you use for tab groups?

This is for the built-in tab groups feature that we're working on.