1926434 - decouple Phabricator revision loading/validation from `show_commit_stack`

Status: RESOLVED FIXED

(Conduit :: moz-phab, task, P3)

Description

[Connor Sheehan [:sheehan]]

show_commit_stack has a validate=True kwarg which causes the method to load revision data from Phabricator and perform checks that set flags on the commit objects, among other things. We should split the data loading out of show_commit_stack so it is purely a method which displays information to the user.

Comment 1

[Mathew Hodson]

Attachment: submit: decouple validation from `show_commit_stack` (Bug 1926434) r=sheehan

Split show_commit_stack into two functions for the two places it is
called. The new validate_commit_stack sets flags on commit objects
and shows warnings. show_commit_stack now just shows the submissions
at the end.

Comment 2

[BMO Github Automation]

Authored by https://github.com/mathewhodson
https://github.com/mozilla-conduit/review/commit/4f2b1d9b49f820e0adbfb4ee3e9e0a99947d9e20
[main] submit: decouple validation from show_commit_stack (Bug 1926434) r=sheehan