1926592 - "GECKO_INSTALLER_URL" environment variable not set for source-tests

Status: NEW

(Firefox Build System :: Task Configuration, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As referenced in the following code there should be a GECKO_INSTALLER_URL environment variable set for source-tests based tests, but that's not the case. This environment variable doesn't exist.

https://searchfox.org/mozilla-central/rev/6ec81d7b1d2f60c18f1de400ac9e8ada1f905352/taskcluster/gecko_taskgraph/transforms/source_test.py#34

        # Build labels required for the task. If this key is provided it must
        # contain a build label for the task platform.
        # The task will then depend on a build task, and the installer url will be
        # saved to the GECKO_INSTALLER_URL environment variable.
        Optional("require-build"): optionally_keyed_by("project", {str: str}),

As workaround the variable can be set by using a by-platform setting under worker like:

    worker:
        by-platform:
            linux1804*:
                env:
                    GECKO_INSTALLER_URL: $MOZ_FETCHES_DIR/target.tar.bz2
            macosx*:
                env:
                    GECKO_INSTALLER_URL: $MOZ_FETCHES_DIR/target.dmg
            windows*:
                env:
                    GECKO_INSTALLER_URL: $MOZ_FETCHES_DIR/target.zip

Maybe this environment variable needs to be set in add_build_dependency()? At least the comment there states that:

def add_build_dependency(config, job):
    """
    Add build dependency to the job and installer_url to env.