1926614 - [wdspec] WebDriver BiDi client modules should validate data types in command responses

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Some of the existing modules at the following location already check value types for validity:
https://searchfox.org/mozilla-central/source/testing/web-platform/tests/tools/webdriver/webdriver/bidi/modules

Given that this is a test client we should do these checks for every command in each of the listed modules.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

If needed we can do the commands first and events later, but preferable we could have both at once.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

@Khalid maybe this would be an interesting bug for you. Here you would have to work with the WebDriver BiDi specification to find the proper types to check.

Comment 3

[Khalid AlHaddad]

Yes, I'd be happy to work on it.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Great to hear that! Let me know if something is unclear. I'm happy to discuss on Matrix (or here as well).

Comment 5

[Khalid AlHaddad]

Thank you, and will do if anything comes up.

Comment 6

[Khalid AlHaddad]

Thank you, and will do if anything comes up.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

As discussed on Matrix we cannot actually do it for events because we do not have special handling as for commands:

https://searchfox.org/firefox-main/rev/ac7d7c131dd65058ad6b7ecfa65dc8f31a0f203e/testing/web-platform/tests/tools/webdriver/webdriver/bidi/client.py#217-226

Comment 8

[Khalid AlHaddad]

Attachment: Bug 1926614 - WebDriver BiDi client modules should validate data types in command responses. r?#webdriver-reviewers

Comment 9

[Khalid AlHaddad]

Attachment: Bug 1926614 - Sorted methods alphabetically. r?#webdriver-reviewers

Comment 10

[Khalid AlHaddad]

Attachment: fixup! Bug 1926614 - WebDriver BiDi client modules should validate data types in command responses. r?#webdriver-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e898637063e4
https://hg.mozilla.org/integration/autoland/rev/efe8e32fdf72
WebDriver BiDi client modules should validate data types in command responses. r=whimboo
https://github.com/mozilla-firefox/firefox/commit/5aac518f5191
https://hg.mozilla.org/integration/autoland/rev/46d55438e827
Sorted methods alphabetically. r=jgraham,whimboo

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/57288 for changes under testing/web-platform/tests

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/efe8e32fdf72
https://hg.mozilla.org/mozilla-central/rev/46d55438e827

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Thank you Khalid! As discussed on Matrix I've taken a look for a next opportunity for you and bug 2003820 would be a good one so that we can clean-up all of our WebDriver related tests. What do you think?

Comment 16

[Khalid AlHaddad]

Yes, I agree it's good.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/67a61fe3c37b
https://hg.mozilla.org/integration/autoland/rev/e6ab9bd7c9cc
[wpt PR 57288] - [Gecko Bug 1926614] WebDriver BiDi client modules should validate data types in command responses., a=testonly

Comment 18

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e6ab9bd7c9cc